I am not super impressed with code quality. Things like:
lib/md5.c:130:23: warning: argument to 'sizeof' in 'memset' call is the same expression as the destination; did you mean to dereference it? [-Wsizeof-pointer-memaccess]
memset(ctx, 0, sizeof(ctx)); /* In case it's sensitive */
I am not super impressed with code quality. Things like:
lib/md5.c:130:23: warning: argument to 'sizeof' in 'memset' call is the same expression as the destination; did you mean to dereference it? [-Wsizeof- pointer- memaccess]
memset(ctx, 0, sizeof(ctx)); /* In case it's sensitive */
And plenty of:
lib/pdu.c:239:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
ttt = ntohl(*(uint32_t *)&in->hdr[20]);
As for tests, is there a way we could run them as a dep8 test, and run a local server during it?