Comment 12 for bug 1864061

Revision history for this message
Hui Wang (hui.wang) wrote :

We need to backport the this commint, this is already backported to 5.4 focal kernel, but it is not in the eoan kernel yet:

commit 8ce1cbd6ce0b1bda0c980c64fee4c1e1378355f1
Author: Jaroslav Kysela <email address hidden>
Date: Wed Jan 22 20:07:52 2020 +0100

    ASoC: topology: fix soc_tplg_fe_link_create() - link->dobj initialization order

    The code which checks the return value for snd_soc_add_dai_link() call
    in soc_tplg_fe_link_create() moved the snd_soc_add_dai_link() call before
    link->dobj members initialization.

    While it does not affect the latest kernels, the old soc-core.c code
    in the stable kernels is affected. The snd_soc_add_dai_link() function uses
    the link->dobj.type member to check, if the link structure is valid.

    Reorder the link->dobj initialization to make things work again.
    It's harmless for the recent code (and the structure should be properly
    initialized before other calls anyway).

    The problem is in stable linux-5.4.y since version 5.4.11 when the
    upstream commit 76d270364932 was applied.

    Fixes: 76d270364932 ("ASoC: topology: Check return value for snd_soc_add_dai_link()")
    Cc: Dragos Tarcatu <email address hidden>
    Cc: Pierre-Louis Bossart <email address hidden>
    Cc: Ranjani Sridharan <email address hidden>
    Cc: Mark Brown <email address hidden>
    Cc: <email address hidden>
    Signed-off-by: Jaroslav Kysela <email address hidden>
    Link: https://<email address hidden>
    Signed-off-by: Mark Brown <email address hidden>