Comment 3 for bug 105709

Revision history for this message
Martin Pitt (pitti) wrote :

Comments about SRU:

* Please get this fixed and tested in gutsy first.
* The patch (r520) should be polished a bit: [ !$(which pulseaudio) ] => ! type pulseaudio >/dev/null 2>&1
  This avoids unsafe quoting, the lack of a test operator, and avoids a subshell.
* The changelog (r521) should not talk about 'added fixed script', but explain the change and the impact.