Comment 6 for bug 874981

Revision history for this message
Dave Walker (davewalker) wrote :

Hi Marc,

Thanks for the debdiff. Great work.

I did have a couple of comments.

I'm not sure I agree that the debian/control diff of the Description fields is ideal, is this required? For example:
-Description: Marionette Collective clustering framework - server
+Description: build server orchestration or parallel job execution systems

debian/changelog: Could do with a more descriptive entry, it doesn't really describe what has changed or been dropped.

debian/mcollective-middleware.postinst: Calls the service command directly, it's going to be safer to do
- service activemq stop
- service activemq start
+ invoke-rc.d activemq stop || :
+ invoke-rc.d activemq start

Thanks!