Comment 48 for bug 1113166

Revision history for this message
In , Landry-openbsd (landry-openbsd) wrote :

(In reply to Sean Stangl from comment #38)
> Status update: all known issues are resolved, and darkxst's patches are
> awaiting final review after some iteration. Judging by the length of time
> required to get approval for esr17, it looks like we'll be carrying a number
> of patches outside of the main repo, but that isn't a barrier to shipping.
> Builds and installs fine on OSX.
>
> Latest version (built from https://github.com/sstangl/js-packaging):
> http://www.contrib.andrew.cmu.edu/user/sstangl/mozjs17-0.0.2.tar.gz

Fwiw i've tried that tarball on OpenBSD, all regress tests pass fine and i'm really happy with the changes made to packaging/versionning of include dir/binaries.. less local patches!

- one for Makefile.in to disable yarr jit on sparc64 (which is broken anyway, but if it builds it allows some depending pkgs to build)

-ifneq (,$(filter arm% sparc %86 x86_64 mips%,$(TARGET_CPU)))
+ifneq (,$(filter arm% sparc* %86 x86_64 mips%,$(TARGET_CPU)))

- one for configure.in setting our SO_VERSION from env (need to file it to get that commited, its a followup from #648721)

- DLL_SUFFIX=".so.1.0"
+ DLL_SUFFIX=".so.${SO_VERSION}"

- http://hg.mozilla.org/tracemonkey/rev/68203913d04c backported to esr17 for sparc64, i realized bug #618485 was only commited to tracemonkey repo, and didnt made it to m-c or esr17. Will file that one too.

Only one nit : 17.0 or mozjs17 is really confusing, given that we come from 1.8.5.. it almost looks that we downgrade the version. For 1.8.5 it matched the version of the JavaScript Language..