Comment 7 for bug 1682631

I also tried adding
export DEB_CFLAGS_MAINT_APPEND = -fno-strict-aliasing
to debian/rules. I don't know much about debian packages and how that would normally work, but I don't see how that would ever get picked up by their config/make system. It doesn't appear to be having any effect at all.

Here's what I did to get the test failures down to 0 on gcc6:

1. modify the code at line 3908 in js/src/configure.in to do -fno-strict-aliasing no matter what the gcc version is:

dnl ========================================================
dnl = Disable -fstrict-aliasing with GCC
dnl = See bugs 821502 and 832623.
dnl ========================================================
if test -n "$GNU_CC" -a -z "$CLANG_CC"; then
    CFLAGS="$CFLAGS -fno-strict-aliasing"
    CXXFLAGS="$CXXFLAGS -fno-strict-aliasing"
fi

2. cd js/src
3. autoconf2.13 #regen configure
4. ./configure #reconfigure
5. make clean
6. make #watch and see the -fno-strict-aliasing
7.
make check-jstests | grep -c UNEXPECTED-FAIL
0

PS. This seems to be mostly unrelated to the fix-gcc6-segfault.patch. If I remove fix-gcc6-segfault.patch, the test failures go back up. So what I'm purposing doesn't replace the need for fix-gcc6-segfault.patch. I think it should be treated separately.