© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
The changes to pango should in quilt format, I've extracted the patch from the bug and am attaching here.
Review of the patch:
- It is a large and complex change
- There are a number of unnecessary changes, e.g. whitespace or comments that seem obsolete. This will make the patch an ongoing problem to apply
- Upstream has closed the bug as fixed and not allowed the patch to be applied to trunk. I'm not sure what the reason for this is.
For the above reasons I can't tell how correct this patch is, and the change seems to carry a lot of risk and has an ongoing maintenance issue.
Arjuna, for this patch to be accepted I would want to see someone experienced in Pango to review it and say it is safe/correct, and the patch be as small as possible so it only contains the required changes.