Comment 47 for bug 120281

(From update of attachment 259815)
Thx very much for working on this!

We don't really need to put bug #'s in the code - cvsblame will allow us find the bug, because the checkin comment will refer to the bug number.

we prefer spaces around operators, so i=0 should be i = 0, i==0 should be i == 0, or !i, i-1 should be i - 1.

What happens if the line terminator is '\r'? Or does the mac not use '\r' anymore? From lxr, it looks like it uses '\n', so your code should be ok.

The var name "j" is not meaningful - it would make the code a lot more readable if the var name indicated what "j" was - I think it's the index of the last char in the line, and if that char is a ' ', you're replacing the line terminating char(s) with ' '. So the code is basically doing this:

Look for unquoted lines - if we have an unquoted line that ends in a space, replace the end of line char(s) with spaces.

It would be good to have a comment that says that...

If that's correct, could you attach a new patch that addresses these comments? Thx!