Comment on attachment 8956310 Bug 440908 - Add support for `sticky` and `locked` attributes to default prefs.
https://reviewboard.mozilla.org/r/225184/#review231212
::: modules/libpref/Preferences.cpp:3982 (Diff revision 1) > - Preferences::GetCString(kChannelPref, updateChannelPrefValue, > - PrefValueKind::Default); > + Preferences::GetCString( > + kChannelPref, updateChannelPrefValue, PrefValueKind::Default); > releaseCandidateOnBeta = updateChannelPrefValue.EqualsLiteral("beta"); > } > > if (!strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "nightly") || > !strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "aurora") || > - !strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "beta") || > + !strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "beta") || developerBuild ||
clang-format changed its mind, I guess?
::: modules/libpref/parser/src/lib.rs:282 (Diff revision 1) > struct KeywordInfo { > string: &'static [u8], > token: Token, > } > > -const KEYWORD_INFOS: &[KeywordInfo; 5] = &[ > +const KEYWORD_INFOS: &[KeywordInfo; 7] = &[
In passing, AFAIK, this could actually me [KeywordInfo; 7] (without the ref)
Comment on attachment 8956310
Bug 440908 - Add support for `sticky` and `locked` attributes to default prefs.
https:/ /reviewboard. mozilla. org/r/225184/ #review231212
::: modules/ libpref/ Preferences. cpp:3982 :GetCString( kChannelPref, updateChannelPr efValue, :Default) ; :GetCString( efValue, PrefValueKind: :Default) ; eOnBeta = updateChannelPr efValue. EqualsLiteral( "beta") ; NS_STRINGIFY( MOZ_UPDATE_ CHANNEL) , "nightly") || NS_STRINGIFY( MOZ_UPDATE_ CHANNEL) , "aurora") || NS_STRINGIFY( MOZ_UPDATE_ CHANNEL) , "beta") || NS_STRINGIFY( MOZ_UPDATE_ CHANNEL) , "beta") || developerBuild ||
(Diff revision 1)
> - Preferences:
> - PrefValueKind:
> + Preferences:
> + kChannelPref, updateChannelPr
> releaseCandidat
> }
>
> if (!strcmp(
> !strcmp(
> - !strcmp(
> + !strcmp(
clang-format changed its mind, I guess?
::: modules/ libpref/ parser/ src/lib. rs:282
(Diff revision 1)
> struct KeywordInfo {
> string: &'static [u8],
> token: Token,
> }
>
> -const KEYWORD_INFOS: &[KeywordInfo; 5] = &[
> +const KEYWORD_INFOS: &[KeywordInfo; 7] = &[
In passing, AFAIK, this could actually me [KeywordInfo; 7] (without the ref)