Comment 10 for bug 439284

Revision history for this message
Loïc Minier (lool) wrote :

17:45 < lool> Keybuk: poke
17:45 < lool> Keybuk: Do you have any issue with adding this check during boot http://bazaar.launchpad.net/~bratsche/gdm/xsplash-check-cmdline/revision/146 ?
17:45 < Keybuk> makes sense to me
17:45 < Keybuk> though why would you want to disable xsplash?
17:46 < Keybuk> you disable usplash because you want to see things going on under it
17:46 < Keybuk> all that goes on under xsplash is the pinwheel
17:46 < lool> Keybuk: Just in case something goes wrong or you simply don't want it
17:46 -!- ior3k [n=quassel@89.152.50.144] has quit [Read error: 110 (Connection timed out)]
17:46 < ion> That would match anything with a ‘splash’ substring.
17:46 < lool> Keybuk: we had the case where it broke and we had no facility to document a workaround, and some people don't like it
17:46 < lool> ion: I suggested adding -w
17:46 -!- mpt [n=mpt@canonical/mpt] has quit [Operation timed out]
17:46 < Keybuk> though strictly speaking, that grep is wrong
17:47 < Keybuk> since that will match root=/dev/mapper/ubuntu-splash-top
17:47 < Keybuk> -w won't help, since - is a word boundary
17:47 < lool> Hmm true, I think gdm was using that though
17:48 < Keybuk> the gdm upstart job reads /proc/cmdline using for
17:48 < Keybuk> random thought
17:48 < Keybuk> if you check for splash in that list and set an ENVVAR, does that end up in the gdm session scripts
17:48 < Keybuk> ie. could you modify /etc/init/gdm.conf, set SPLASH=true at the top
17:48 < lool> we dont need to send an envvar I guess
17:48 < Keybuk> then when it reads the command-line, set SPLASH=false
17:48 -!- tormod [n=tormod@138.131.217.145] has quit ["Ex-Chat"]
17:48 < Keybuk> (or however that should work)
17:49 < Keybuk> then just check that var in the scripts
17:49 < Keybuk> that'd save you a lot of processor time of re-reading /proc/cmdline a dozen times
17:49 < lool> just for ... splash) start xsplash;
17:49 < Keybuk> (well, not that it's much, but each one adds up)