Comment 5 for bug 1009412

Revision history for this message
Scott Moser (smoser) wrote :

Vibhav,
   I've taken a look at your diff (Revised Debdiff in comment 2 above).
   I have the following comments:
a.) Thank you for your work.
b.) as per IRC conversation [1], please do open a debian bug regarding the Ubuntu delta in debian/patches/01_fix-as-needed- linking.diff, and then link the resulting debian bug to this bug.
c.) it seems that you've re-named the debian patch in debian/patches/fillval to fillval.diff . I think it best to leave it as it is.
d.) In debian/patches/series, you have 01_fix-as-needed-linking.diff first. Generally, I think in ubuntu delta we usually apply the Ubuntu patches last.
e.) Keep the debian/changelog entries from debian as their own entries, rather than as sub-elements of the Ubuntu merge entry.

--
[1] http://irclogs.ubuntu.com/2012/06/06/%23ubuntu-devel.html#t16:44