Comment 11 for bug 888281

Revision history for this message
Colin Watson (cjwatson) wrote :

Please use 'diff -u' when generating diffs. Context diffs are difficult to read, and are especially painful when there's no actual context included. Also, put the previous version on the diff command line before the new version so that the patch doesn't come out reversed.

As for the substance of the patch, I had to think about it a bit to convince myself that it was safe to use Linux's loop device ordering as a unique key for GRUB's loop device naming, but after consideration I agree that it's fine. I'll apply this patch for my next upload.