Merge lp:~gary-lasker/software-center/recommendations-opt-out into lp:software-center
Status: | Merged |
---|---|
Merged at revision: | 2880 |
Proposed branch: | lp:~gary-lasker/software-center/recommendations-opt-out |
Merge into: | lp:software-center |
Diff against target: |
324 lines (+125/-25) 6 files modified
data/ui/gtk3/SoftwareCenter.ui (+16/-6) softwarecenter/ui/gtk3/app.py (+36/-7) softwarecenter/ui/gtk3/views/catview_gtk.py (+1/-1) softwarecenter/ui/gtk3/widgets/containers.py (+4/-0) softwarecenter/ui/gtk3/widgets/recommendations.py (+54/-9) test/gtk3/test_recommendations_widgets.py (+14/-2) |
To merge this branch: | bzr merge lp:~gary-lasker/software-center/recommendations-opt-out |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
software-store-developers | Pending | ||
Review via email: mp+97928@code.launchpad.net |
Description of the change
This branch implements the recommendations opt-out feature as specified in the most recent Software Center spec from mpt (https:/
In the case where the user has not yet opted in, this menu item reads "Turn On Recommendations
Unfortunately, this branch is light on tests for the small amout of new stuff, but in actuality there is not much new code for which tests will be terribly important. The "heavy" code is already tested -- this is really just some small UI additions. Nevertheless, I apologize for that, and a follow-on branch is forthcoming that will improve this coverage. In the interest of getting this last remaining important piece of recommender functionality merged in time for it to be covered under our current outstanding string freeze/UI freeze exception bug 956779, I'm submitting the MP now.
Thanks!
Just a note that I factored the opt-in dialog code to its own class and added some new unit tests so that all of the recommendations panel widget types are tested now.