Ubuntu Software Center

Merge lp:~mvo/software-center/padding-adjustments into lp:software-center

  1. padding-adjustments
  2. Merge into trunk
Proposed by Michael Vogt
Status: Merged
Merged at revision: 3167
Proposed branch: lp:~mvo/software-center/padding-adjustments
Merge into: lp:software-center
Diff against target: 18 lines (+4/-4)
1 file modified
softwarecenter/ui/gtk3/widgets/containers.py (+4/-4)
To merge this branch: bzr merge lp:~mvo/software-center/padding-adjustments
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve
Review via email: mp+123708@code.launchpad.net

Description of the change

This fixes a small visual glitch. When the spinner is displayed in the
LobbyView it draws over the left border of the frame. Adjusting the
padding slightly fixes this.

To post a comment you must log in.
lp:~mvo/software-center/padding-adjustments updated
3161. By Michael Vogt

update comment as I was confused about the order initially for set_padding

Revision history for this message
Gary Lasker (gary-lasker) wrote :

Yes, this looks so much better, thanks Michael!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/ui/gtk3/widgets/containers.py'
2--- softwarecenter/ui/gtk3/widgets/containers.py 2012-09-07 10:25:46 +0000
3+++ softwarecenter/ui/gtk3/widgets/containers.py 2012-09-11 10:34:18 +0000
4@@ -236,10 +236,10 @@
5
6 def __init__(self, padding=0):
7 Gtk.Alignment.__init__(self)
8- # set padding + some additional padding in the bottom, left and
9- # right edges to factor in the dropshadow width, and ensure even
10- # visual border
11- self.set_padding(padding, padding + 2, padding + 1, padding + 1)
12+ # set padding + some additional padding to factor in the
13+ # dropshadow+border width
14+ # padding is (top, bottom, left, right)
15+ self.set_padding(padding, padding + 2, padding + 3, padding + 3)
16
17 self._cache_art_assets()
18 # second tier of caching, cache resultant surface of

Subscribers

People subscribed via source and target branches