Ubuntu Software Center

lp:~gary-lasker/software-center/recommendations-sso-login-lp973612

Created by Gary Lasker and last modified
Get this branch:
bzr branch lp:~gary-lasker/software-center/recommendations-sso-login-lp973612
Only Gary Lasker can upload to this branch. If you are Gary Lasker please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Gary Lasker
Project:
Ubuntu Software Center
Status:
Merged

Recent revisions

2988. By Gary Lasker

merge with trunk

2987. By Gary Lasker

really fix the case on startup if there is no network connection

2986. By Gary Lasker

revert the whoami_error fix as we also get these in the case where the user's token has been revoked or invalidated on the server side (so we do need to fully opt-out in this case), also, handle an sso login-failed event

2985. By Gary Lasker

if there is an error in the whois query, we can assume a network connectivity issue, so we simply hide the recommendations panel as we do for the case where we can't reach the recommendations server

2984. By Gary Lasker

log when the user has cancelled the authorization dialog

2983. By Gary Lasker

login-canceled is more appropriate for the case where the user has canceled the auth dialog

2982. By Gary Lasker

make the purpose of the fixme comment more clear

2981. By Gary Lasker

pep8 fixes

2980. By Gary Lasker

log a warning instead of a scary error in the case where the Ubuntu SSO dialog is canceled by the user (this is a perfectly valid choice and should not be considered an error, seems to me), also, fire a login-failed signal for this case so that listeners can handle it

2979. By Gary Lasker

fix the delay before showing a spinner when checking the Ubuntu SSO status

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:software-center
This branch contains Public information 
Everyone can see this information.

Subscribers