[extra-addons]auto_backup only works when super-administrator password = admin

Bug #1009798 reported by Dries Cox
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
Amit Parik

Bug Description

openerp version 6.0.4
addons-extra
module: auto_backup

in the module auto_backup the super administrator password is hard-coded. So when it is changed then the backups produce files of 0kb. => no backup and you don't know it :-)

file: backup_scheduler.py
line 97
                    bkp = execute(conn, 'dump', 'admin', rec.name)

I changed it to and this seems to do the job:

                    bkp = execute(conn, 'dump', tools.config['admin_passwd'], rec.name)

Related branches

Amit Parik (amit-parik)
affects: openobject-addons → openobject-server
affects: openobject-server → openobject-addons
Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Dries,

You are absolutely correct, in backup_scheduler.py administrator password is hard-coded. Also I have checked this at my end and whenever I changed my super administrator pwd database back up doesn't work correctly additionally I got the following warning msg on server side.

[db_stable6] INFO:backup:Could'nt backup database db_stable6. Bad database administrator password for server running at http://localhost:8069

I have checked your solution and it's working charm,

Thank you!

summary: - auto_backup only works when super-administrator password = admin
+ [extra-addons]auto_backup only works when super-administrator password =
+ admin
Changed in openobject-addons:
assignee: nobody → Amit Parik (OpenERP) (amp-openerp)
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Dries,

This issue has been committed on lp:openobject-addons/extra-6.0 branch with following revision no and id.

5809 <email address hidden>

Thanks!

Changed in openobject-addons:
status: Confirmed → Fix Released
Revision history for this message
Dries Cox (driescox) wrote : Re: [Bug 1009798] Re: [extra-addons]auto_backup only works when super-administrator password = admin

Thank you for the fast response.

:-)

On 07-06-12 12:21, Amit Parik (OpenERP) wrote:
> Hello Dries,
>
> This issue has been committed on lp:openobject-addons/extra-6.0 branch
> with following revision no and id.
>
> 5809 <email address hidden>
>
>
> Thanks!
>
> ** Changed in: openobject-addons
> Status: Confirmed => Fix Released
>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.