In multiple places, BadStoreUri exceptions are incorrectly passing parameters

Bug #1010140 reported by Alex Meade
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Alex Meade

Bug Description

grep raise[[:space:]][a-Z\.]*exception\.[a-Z]*\([[:space:]a-Z]*\, ./* -r
shows us all of the exceptions using multiple arguments.

In a few places BadStoreUri exceptions are being raised incorrectly and causing the error message to be incorrectly formatted.

Currently:
 raise exception.BadStoreUri(uri, reason)

Should be:
 raise exception.BadStoreUri(uri=uri, reason=reason)

Alex Meade (alex-meade)
Changed in glance:
status: New → In Progress
assignee: nobody → Alex Meade (alex-meade)
Brian Waldon (bcwaldon)
Changed in glance:
importance: Undecided → Low
milestone: none → folsom-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/8190
Committed: http://github.com/openstack/glance/commit/e2c52ddfa6b5b6dff88e3d58b55ef7034739bc63
Submitter: Jenkins
Branch: master

commit e2c52ddfa6b5b6dff88e3d58b55ef7034739bc63
Author: Alex Meade <email address hidden>
Date: Tue Jun 5 13:52:23 2012 -0400

    Add tests and simplify GlanceExceptions.

    This also fixes some incorrect use of GlanceException parameters.

    Fixes bug: 1009122
    Fixes bug: 1010140

    Change-Id: Ic77856686a0259da2318e05b15f3d382508c00b9

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: folsom-2 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.