Allow setting preferred media players through a settings key
Bug #1014955 reported by
Victor Martinez
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| The Sound Menu |
Fix Released
|
Wishlist
|
Victor Martinez | ||
Bug Description
While working on a fix for lp:995060 I found that "rhythmbox.desktop" was hardcoded in PlayerControlle
I created a branch that makes it possible to set the list of preferred players by modifying the "preferred-
You can find my work at rev. 5 of lp:~victored/elementaryos/indicator-sound
I can apply the changes to lp:indicator-sound and make a merge proposal if you have no problems with adding this feature.
Related branches
lp:~victored/indicator-sound/lp-1014955
- Conor Curran (community): Approve
-
Diff: 66791 lines (+64977/-1041) (has conflicts)72 files modified.bzrignore (+0/-90)
INSTALL (+370/-0)
Makefile.am.coverage (+48/-0)
Makefile.in (+853/-0)
aclocal.m4 (+10680/-0)
compile (+310/-0)
config.guess (+1530/-0)
config.h.in (+89/-0)
config.sub (+1773/-0)
configure (+17597/-0)
data/Makefile.in (+689/-0)
data/com.canonical.indicator.sound.gschema.xml (+7/-0)
data/icons/16x16/Makefile.in (+620/-0)
data/icons/16x16/status/Makefile.in (+474/-0)
data/icons/Makefile.in (+635/-0)
data/icons/scalable/Makefile.in (+620/-0)
data/icons/scalable/status/Makefile.in (+474/-0)
debian/changelog (+838/-0)
debian/compat (+1/-0)
debian/control (+48/-0)
debian/copyright (+37/-0)
debian/indicator-sound-gtk2.install (+1/-0)
debian/indicator-sound.install (+1/-0)
debian/patches/lp_902715.patch (+50/-0)
debian/patches/lp_992262.patch (+365/-0)
debian/patches/series (+5/-0)
debian/patches/sound_nua.patch (+20/-0)
debian/patches/sound_ubuntustudio.patch (+18/-0)
debian/patches/sound_xubuntu.patch (+17/-0)
debian/rules (+25/-0)
debian/source/format (+1/-0)
debian/watch (+2/-0)
depcomp (+688/-0)
install-sh (+527/-0)
ltmain.sh (+9661/-0)
missing (+331/-0)
mkinstalldirs (+162/-0)
po/Makefile.in.in (+222/-0)
src/Makefile.in (+1314/-0)
src/fetch-file.c (+561/-0)
src/fetch-file.vala (+0/-86)
src/freedesktop-interfaces.c (+862/-0)
src/gen-sound-service.xml.c (+36/-0)
src/gen-sound-service.xml.h (+1/-0)
src/metadata-menu-item.c (+863/-0)
src/mpris2-controller.c (+1769/-0)
src/mpris2-interfaces.c (+2655/-0)
src/mpris2-watcher.c (+838/-0)
src/music-player-bridge.c (+1420/-0)
src/music-player-bridge.h (+605/-0)
src/music-player-bridge.vala (+84/-2)
src/player-controller.c (+1082/-0)
src/player-controller.vala (+21/-4)
src/player-item.c (+598/-0)
src/player-item.vala (+0/-104)
src/playlists-menu-item.c (+873/-0)
src/scrub-menu-item.vala (+0/-56)
src/settings-manager.c (+491/-0)
src/settings-manager.vala (+24/-2)
src/sound-service-marshal.c (+89/-0)
src/sound-service-marshal.h (+20/-0)
src/specific-items-manager.c (+598/-0)
src/transport-menu-item.c (+384/-0)
tests/Makefile.am (+0/-151)
tests/mockpulse.c (+0/-105)
tests/mockpulse.h (+0/-26)
tests/run-xvfb.sh (+0/-8)
tests/test-defines.h (+0/-25)
tests/test-indicator-sound-dbus-client.c (+0/-110)
tests/test-indicator-sound-dbus-server.c (+0/-63)
tests/test-pulse-manager.c (+0/-139)
vapi/common-defs.vapi (+0/-70)
| Changed in indicator-sound: | |
| importance: | Undecided → Wishlist |
| Changed in indicator-sound: | |
| status: | New → Confirmed |
Revision history for this message
| Conor Curran (cjcurran) wrote | #1 |
| Changed in indicator-sound: | |
| assignee: | nobody → Conor Curran (cjcurran) |
| status: | Confirmed → Fix Committed |
| assignee: | Conor Curran (cjcurran) → Victor Eduardo (victored) |
Revision history for this message
| Victor Martinez (victored) wrote | #2 |
Revision history for this message
| Conor Curran (cjcurran) wrote | #3 |
| Changed in indicator-sound: | |
| status: | Fix Committed → Fix Released |
| milestone: | none → 12.10.0 |
To post a comment you must log in.
Thanks Victor,
All merged.