Wrong reference in windows document

Thanks for your bug. Same on my English copy of Windows XP at work.

Unfortunately, Windows XP has two ways of displaying the Control Panel. IIRC, the default on Windows XP Home and Professional is a purple/blue 'basic' view. I think I wrote the instructions for this view.

If you have switched to 'advanced' mode (see the first (?) option in the sidebar), the Control Panel will have a white background. I think you're probably using this view.

A possible fix for this would be to include two sets of instructions, e.g.:

"If the background is purple, press abc. If the background is white, press xyz."

The file which needs to be edited is trunk/ubuntu/switching/C/preparing.xml, and the offending sentence is on line 204.

Hint: Change the line to something like the following:

<listitem><para>Press <menuchoice><guimenuitem>Start</guimenuitem><guimenuitem>Control Panel</guimenuitem></menuchoice>. If the Control Panel has a purple background, press <menuchoice><guimenuitem>Network and Internet Connections</guimenuitem><guimenuitem>Internet Options</guimenuitem></menuchoice>. If the Control Panel has a white background...</para></listitem>

I've written the small patch as you said.

Validating it gives me "IDERF attribute..." errors... but apart from this it should be correct.

Hi Milo, thanks for the patch. I'll review it a little later when I review your other patch from a while ago.

Regarding the IDREF errors, it turns out that it was just me being stupid. According to mdke, the errors happen when you validate the files individually, rather than as part of a 'book', as intended. Don't worry about them, the documents are actually valid.

Hi Milo, I've reviewed your patch and it looks good. However, I think that it might be worth splitting-up the two different instructions by using a list, for example:

1. Press Start → Control Panel.
  * If the Control Panel has a purple background, press Network and Internet Connections → Internet Options.
  * If the Control Panel has a white background, press Internet Options.
2. On the Connections tab, press LAN Settings...
3. etc.

What do you think? I'm happy to commit the patch either way.

Il giorno sab, 28/07/2007 alle 15.04 +0000, Phil Bull ha scritto:
> Hi Milo, I've reviewed your patch and it looks good. However, I think
> that it might be worth splitting-up the two different instructions by
> using a list, for example:
>
> 1. Press Start → Control Panel.
> * If the Control Panel has a purple background, press Network and Internet Connections → Internet Options.
> * If the Control Panel has a white background, press Internet Options.
> 2. On the Connections tab, press LAN Settings...
> 3. etc.
>
> What do you think? I'm happy to commit the patch either way.

I've checked it on the fly with yelp and yes, it's better splitting it
up with a list...

I'm working on it!

--
Milo Casagrande <email address hidden>

Here comes the patch!

Awesome! I've uploaded the patch (r4188).

Thanks Milo.