[MIR] cinder

This FTBFS since python-babel is not in main.

MIR review:
 * Builds fine
 * Has a testsuite, but it is disabled in the build. Since there were several nova-volume tests in nova, this is a regression over 12.04.
 * python2, but it is a server application, so that is ok
 * cinder is not in Debian
 * ubuntu-server is subscribed to its bugs
 * Has a watch file
 * Not lintian clean (related to 1022641, but more errors now):
cinder-api_2012.2~f1~20120503.2-0ubuntu1_all.deb:
E: cinder-api: postrm-does-not-call-updaterc.d-for-init.d-script etc/init.d/cinder-api
W: cinder-api: binary-without-manpage usr/bin/cinder-api

cinder-common_2012.2~f1~20120503.2-0ubuntu1_all.deb:
W: cinder-common: binary-without-manpage usr/bin/cinder-manage
W: cinder-common: binary-without-manpage usr/bin/cinder-rootwrap
W: cinder-common: binary-without-manpage usr/bin/clear_rabbit_queues

cinder-scheduler_2012.2~f1~20120503.2-0ubuntu1_all.deb:
E: cinder-scheduler: postrm-does-not-call-updaterc.d-for-init.d-script etc/init.d/cinder-scheduler
W: cinder-scheduler: binary-without-manpage usr/bin/cinder-scheduler

cinder-volume_2012.2~f1~20120503.2-0ubuntu1_all.deb:
E: cinder-volume: postrm-does-not-call-updaterc.d-for-init.d-script etc/init.d/cinder-volume
W: cinder-volume: binary-without-manpage usr/bin/cinder-volume

python-cinder_2012.2~f1~20120503.2-0ubuntu1_all.deb:
W: python-cinder: wrong-section-according-to-package-name python-cinder => python
 * debian/rules is clean
 * package build has a lot of warnings:
warning: no directories found matching 'cinder/CA'
warning: no directories found matching 'smoketests'
warning: no directories found matching 'plugins'
warning: no files found matching 'cinder/auth/*.schema'
warning: no files found matching 'cinder/auth/cinderrc.template'
warning: no files found matching 'cinder/auth/opendj.sh'
warning: no files found matching 'cinder/auth/slap.sh'
warning: no files found matching 'cinder/virt/interfaces.template'
warning: no files found matching 'cinder/virt/libvirt*.xml.template'
warning: no files found matching 'cinder/virt/cpuinfo.xml.template'
warning: no files found matching 'cinder/tests/db/cinder.austin.sqlite'
warning: no files found matching 'cinder/tests/image/*.tar.gz'
warning: no files found matching 'cinder/tests/xenapi/vm_rrd.xml'
warning: no files found matching 'plugins/xenapi/README'
warning: no files found matching 'plugins/xenapi/etc/xapi.d/plugins/objectstore'
warning: no files found matching 'plugins/xenapi/etc/xapi.d/plugins/pluginlib_cinder.py'
warning: no previously-included files matching '*.pyc' found anywhere in distribution
warning: no directories found matching 'cinder/CA'
warning: no directories found matching 'smoketests'
warning: no directories found matching 'plugins'
warning: no files found matching 'cinder/auth/*.schema'
warning: no files found matching 'cinder/auth/cinderrc.template'
warning: no files found matching 'cinder/auth/opendj.sh'
warning: no files found matching 'cinder/auth/slap.sh'
warning: no files found matching 'cinder/virt/interfaces.template'
warning: no files found matching 'cinder/virt/libvirt*.xml.template'
warning: no files found matching 'cinder/virt/cpuinfo.xml.templ...

Security review:
Per http://wiki.openstack.org/Cinder just moves nova-volume out on its own. Code inspection shows this to be the case. nova-volume is already in main so a separate security review for cinder is not required. That said, nova-volume used nova-rootwrap and while cinder ships cinder-rootwrap, the packaging does not set it up by default.

Conditional ACK provided the following are met:
 * test suite is enabled
 * Bugs 1030192, 1022641 and 1030197 are fixed
 * warnings during package build are cleaned up
 * use cinder-rootwrap by default

cinder should be ok now.

The changes introduced bug #1036240.

I don't think the changes were applied in bug #1036240. I don't see it in the bzr tree or http://launchpadlibrarian.net/112887645/cinder_2012.2~f3~20120809.102-0ubuntu2_2012.2~f3-0ubuntu1.diff.gz

Hi,

The latest upload should have these fixes now.

chuck

This still isn't working. All I am trying to do is this:
$ sudo apt-get install cinder*

and it is dying because of cinder-common (2012.2~f3-0ubuntu2).

Ok, ubuntu3 solves the installation issues. I have verified that cinder is using the root wrapper by default. One last question, /etc/cinder/rootwrap.conf has the following:

[DEFAULT]
# List of directories to load filter definitions from (separated by ',').
# These directories MUST all be only writeable by root !
filters_path=/etc/cinder/rootwrap.d,/usr/share/cinder/rootwrap

While /etc/cinder/rootwrap.d exists and contains volume.filters, /usr/share/cinder/rootwrap does not exist. I guess this is consistent with other rootwrapped packages (eg, nova is the same). Can someone comment on the purpose of /usr/share/cinder/rootwrap and if it should be populated?

The /usr/share/cinder/rootwrap seems to be optional, it is not popluated by default on Ubuntu and for any other platform that I know about (however SuSe/Redhat might place filers there).

ACK. Feel free to seed or pull in as dependency of something in main.

This has been added to a seed, and will show in c-m shortly.

Override component to main
cinder 2012.2~f3-0ubuntu3 in quantal: universe/net -> main
cinder-api 2012.2~f3-0ubuntu3 in quantal amd64: universe/net/extra -> main
cinder-api 2012.2~f3-0ubuntu3 in quantal armel: universe/net/extra -> main
cinder-api 2012.2~f3-0ubuntu3 in quantal armhf: universe/net/extra -> main
cinder-api 2012.2~f3-0ubuntu3 in quantal i386: universe/net/extra -> main
cinder-api 2012.2~f3-0ubuntu3 in quantal powerpc: universe/net/extra -> main
cinder-common 2012.2~f3-0ubuntu3 in quantal amd64: universe/net/extra -> main
cinder-common 2012.2~f3-0ubuntu3 in quantal armel: universe/net/extra -> main
cinder-common 2012.2~f3-0ubuntu3 in quantal armhf: universe/net/extra -> main
cinder-common 2012.2~f3-0ubuntu3 in quantal i386: universe/net/extra -> main
cinder-common 2012.2~f3-0ubuntu3 in quantal powerpc: universe/net/extra -> main
cinder-scheduler 2012.2~f3-0ubuntu3 in quantal amd64: universe/net/extra -> main
cinder-scheduler 2012.2~f3-0ubuntu3 in quantal armel: universe/net/extra -> main
cinder-scheduler 2012.2~f3-0ubuntu3 in quantal armhf: universe/net/extra -> main
cinder-scheduler 2012.2~f3-0ubuntu3 in quantal i386: universe/net/extra -> main
cinder-scheduler 2012.2~f3-0ubuntu3 in quantal powerpc: universe/net/extra -> main
cinder-volume 2012.2~f3-0ubuntu3 in quantal amd64: universe/net/extra -> main
cinder-volume 2012.2~f3-0ubuntu3 in quantal armel: universe/net/extra -> main
cinder-volume 2012.2~f3-0ubuntu3 in quantal armhf: universe/net/extra -> main
cinder-volume 2012.2~f3-0ubuntu3 in quantal i386: universe/net/extra -> main
cinder-volume 2012.2~f3-0ubuntu3 in quantal powerpc: universe/net/extra -> main
python-cinder 2012.2~f3-0ubuntu3 in quantal amd64: universe/net/extra -> main
python-cinder 2012.2~f3-0ubuntu3 in quantal armel: universe/net/extra -> main
python-cinder 2012.2~f3-0ubuntu3 in quantal armhf: universe/net/extra -> main
python-cinder 2012.2~f3-0ubuntu3 in quantal i386: universe/net/extra -> main
python-cinder 2012.2~f3-0ubuntu3 in quantal powerpc: universe/net/extra -> main
Override [y|N]? y
26 publications overridden.

this appears in component mismatches, python-cinder now requiring python-babel again

Doko promoted python-babel in bug 941913, so this can be closed again.