Image delete notification sends old image info instead of deleted image info

The earlier commit wanted to ensure that image properties are sent in the notification.

Fix proposed to branch: master
Review: https://review.openstack.org/11945

If deleted_at is not present, it should be almost exactly the same to simply use the "timestamp" field in the notification.

I can't see any good reason to include "deleted" and "deleted_at" in image.delete notifications. They answer questions that have no legitimate reason for being asked. To be clear, if you see an image.deleted notification, then implicitly deleted = True. The time it was deleted is the same as the timestamp when the notification was generated.

So now we just need to remove the "deleted" and "deleted_at" fields from the notifications in the domain layer.

Fix proposed to branch: master
Review: https://review.openstack.org/36758

Justin,

A related bug has been reported https://bugs.launchpad.net/glance/+bug/1201701.

Since you already have a patch up for it, would you like to restore it?

Yeah.. I'll restore the merge-prop

Sent from my iPhone

> On Nov 24, 2013, at 12:06, "Iccha Sethi" <email address hidden> wrote:
>
> Justin,
>
> A related bug has been reported
> https://bugs.launchpad.net/glance/+bug/1201701.
>
> Since you already have a patch up for it, would you like to restore it?
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1041332
>
> Title:
> Image delete notification sends old image info instead of deleted
> image info
>
> Status in OpenStack Image Registry and Delivery Service (Glance):
> In Progress
>
> Bug description:
> One of the earlier commits(51faf289) introduced this change:
>
>
> - image = registry.delete_image_metadata(req.context, id)
> + registry.delete_image_metadata(req.context, id)
>
> so later when notification is sent out
>
> self.notifier.info('image.delete', image)
>
> it sends the old image info instead of deleted image info. This in
> turn results in the image having fields with deleted=False and
> deleted_at=null
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/glance/+bug/1041332/+subscriptions

Actually looking at the old fix.. I am not sure it is a good solution.

Cleaning up, lets open this again if it is still an issue.