Launchpad itself

Specification sharing policy is not honored by the edit information_type widget

Bug #1052551 reported by Curtis Hovey
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Richard Harding

Bug Description

Blueprint information portlet "edit" icon because the anchor's style has display:inline. This contradicts the action-icon class which sets the display to inline-block. If this is caused by javascript trying to change the link's visibility, it the script needs to add/remove the hidden class as is done by all other launchpad scripts.

Related branches

lp:~rharding/launchpad/info_portlet_1052551
Benji York (community): Approve (code)
Diff: 85 lines (+26/-18)
4 files modified
lib/lp/blueprints/javascript/addspec.js (+1/-1)
lib/lp/blueprints/templates/blueprint-portlet-privacy.pt (+12/-5)
lib/lp/blueprints/templates/specification-index.pt (+4/-4)
lib/lp/bugs/templates/bug-portlet-privacy.pt (+9/-8)
Revision history for this message
Deryck Hodge (deryck) wrote :

I can't reproduce this. Can you give me a bit more info on what spec to look at, or where you see it?

Changed in launchpad:
status: Triaged → Incomplete
Revision history for this message
Curtis Hovey (sinzui) wrote :

The bug has mutated ;) https://blueprints.qastaging.launchpad.net/launchpad-help-moin-theme/+spec/testing-proprietary-1 once let me change the information type using the portlet. Now no one can change the information type. This is probably wrong because launchpad-help-moin-theme blueprint sharing policy is proprietary, can be public. user must be able to change public to proprietary when the policy permits so that they can quickly fix a mistake. I do not nee any way to change the information type to prevent disclosure on qastaging.

Once we can change blueprint information types, we can check if the script is still setting the display attr...
/me searches code for inline and icon
Ah! why don't we see their error more often?
I see lib/lp/app/javascript/choiceedit/choiceedit.js is setting style when we want to toggle class:
    this.get('editicon').setStyle('display', 'inline');
I would have thought I would be seeing this broken in many places. This is the only case of icons and inline that I see in the code, but there are several cases where none, inline, and block are used and assume the thing is one of those types. Maybe we want to forbid calling
    .setStyle('display', 'XXX');
and instead require toggleClass('hidden')

Revision history for this message
Deryck Hodge (deryck) wrote :

urgh. It sounds like we need a couple of bugs. How about we make this one about specification policy not being honored for editing information_type, and then file a new one for the choiceedit widget's sins?

Revision history for this message
Curtis Hovey (sinzui) wrote :

Agreed. I will report the choiceedit as a separate bug...with luck Ian will see it and get angry and fix it while we sleep.

Revision history for this message
Deryck Hodge (deryck) wrote :

I've updated this bug. Thanks for the feedback and help, Curtis!

summary: - Blueprint information portlet "edit" shown by broken style
+ Specification sharing policy is not honored by the edit information_type
+ widget
Changed in launchpad:
status: Incomplete → Triaged
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r16150 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/16150>.

Changed in launchpad:
assignee: nobody → Richard Harding (rharding)
tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → Fix Committed
Richard Harding (rharding)
tags: added: qa-ok
removed: qa-needstesting
Richard Harding (rharding)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.