[MIR] webapps packages

polib is approved. Has test suite, builds both python3 and python2 versions, uses dh_pythonX, we're in sync, builds clean, no security history, no important bugs.

<mdeslaur> mterry: seeing as how mozjs is ripe with known security vulnerabilities because the standalone version is unmaintained, I'd say it has a pretty slim chance of making it in main
<mdeslaur> mterry: probably worth opening a separate MIR for it

So webapps-applications only uses gjs/mozjs for building. We don't likely want mozjs in main. But what about bundling a copy in webapps-applications?

That way we could avoid a loose mojzs in main. Assigning to security team for a check on this crazy idea.

It's possible (hopefully, not sure about some of the javascript libraries we are using in the test system they might require mozjs features) to replace gjs/mozjs relatively easily (but not trivially) with Seed/libjavascriptcoregtk. libjavascriptcoregtk seems to be already in main.

Robert, security team doesn't want that either. They are trying to reduce usage of webkit as is.

Another idea is to drop the need for JS. It is apparently used for 2 things right now: the test suite and generating bindings. If we could generate bindings at tarball time and use dep8 for the tests, we wouldn't need JS in the build... I think Robert is looking into that now.

OK, looks like we can get a tarball that doesn't need JS to build (except for tests).

unity-firefox-extension looks mostly OK. With the understanding that Chris Coulson looked at it, I've looked it over and it seems OK.

The one issue was that the test suite wasn't being run, but I fixed that in the packaging. And with that fix, I see one of the tests fail. That's being looked into. So once that is fixed, I would approve.

webapps-applications looks fine, after a new release and fixes to the packaging to make it not need gjs. The test suite turns out to not be runnable by Ubuntu after all, since it needs username/passwords to various web sites to work.

But upstream does run it on their Jenkins setup. So I think that will have to suffice.

Nits:
* desktop files would ideally be namespaced (prefixed) with "webapps-", so something like "webapps-amazon.desktop" or something.
* The two default icons (amazon, ubuntuone-music) needn't be installed in hicolor. You already ship them in the private icon stash. Just point the desktop files at the full path.
* Why are the two default .desktop files launched differently? One uses xdg-open and one uses unity-webapps-runner.

Hi Michael! Some comments on the nits:

The naming is a little tricky! the ubuntuone desktop is named the same one as the unity-webapps generated one so it will be replaced once the webapp is initialized. I am open (and enthused) to changing the naming scheme for the R cycle but am unwilling to touch that code at this point as I am not confident of each place which may depend on the naming scheme.

Default icon point seems good to me...trying to puzzle out if there is any reason to have the icon in hicolor

The ubuntu one music app just launches the browser to the u1 music URL at which point the webapp initializes, creating the unity-webapps generated desktop file (which will use unity-webapps-runner).

In the Amazon case it is using a special option to unity-webapps-runner for selecting the proper amazon locale based on geoclue information. Amazon is a special case.

I'll approve greasemonkey plugin too, based on its basic simplicity and the understanding that Chris Coulson looked at it already. Upstream is very active, builds fine.

It doesn't have a test suite yet, which I don't like. So I filed bug 1053621 to track that.

Regarding mozjs for the testsuite-- disabling the testsuite in the build is fine. If instructions can be given on how to run the tests, I'll add a QRT test for webapps-applications that can be used to run the tests. This can be pulled into automated tests, used for SRUs and by the security team.

In my packaging branch, test has been fixed. Approved.

Override component to main
polib 1.0.0-2 in quantal: universe/python -> main
python-polib 1.0.0-2 in quantal amd64: universe/python/optional -> main
python-polib 1.0.0-2 in quantal armel: universe/python/optional -> main
python-polib 1.0.0-2 in quantal armhf: universe/python/optional -> main
python-polib 1.0.0-2 in quantal i386: universe/python/optional -> main
python-polib 1.0.0-2 in quantal powerpc: universe/python/optional -> main
python-polib-doc 1.0.0-2 in quantal amd64: universe/doc/optional -> main
python-polib-doc 1.0.0-2 in quantal armel: universe/doc/optional -> main
python-polib-doc 1.0.0-2 in quantal armhf: universe/doc/optional -> main
python-polib-doc 1.0.0-2 in quantal i386: universe/doc/optional -> main
python-polib-doc 1.0.0-2 in quantal powerpc: universe/doc/optional -> main
python3-polib 1.0.0-2 in quantal amd64: universe/python/optional -> main
python3-polib 1.0.0-2 in quantal armel: universe/python/optional -> main
python3-polib 1.0.0-2 in quantal armhf: universe/python/optional -> main
python3-polib 1.0.0-2 in quantal i386: universe/python/optional -> main
python3-polib 1.0.0-2 in quantal powerpc: universe/python/optional -> main
16 publications overridden.

Override component to main
unity-firefox-extension 2.3.2-0ubuntu1 in quantal: universe/web -> main
libufe-xidgetter0 2.3.2-0ubuntu1 in quantal amd64: universe/libs/optional -> main
libufe-xidgetter0 2.3.2-0ubuntu1 in quantal armel: universe/libs/optional -> main
libufe-xidgetter0 2.3.2-0ubuntu1 in quantal armhf: universe/libs/optional -> main
libufe-xidgetter0 2.3.2-0ubuntu1 in quantal i386: universe/libs/optional -> main
libufe-xidgetter0 2.3.2-0ubuntu1 in quantal powerpc: universe/libs/optional -> main
xul-ext-unity 2.3.2-0ubuntu1 in quantal amd64: universe/web/optional -> main
xul-ext-unity 2.3.2-0ubuntu1 in quantal armel: universe/web/optional -> main
xul-ext-unity 2.3.2-0ubuntu1 in quantal armhf: universe/web/optional -> main
xul-ext-unity 2.3.2-0ubuntu1 in quantal i386: universe/web/optional -> main
xul-ext-unity 2.3.2-0ubuntu1 in quantal powerpc: universe/web/optional -> main
webapps-applications 2.4.6-0ubuntu2 in quantal: universe/gnome -> main
unity-webapps-common 2.4.6-0ubuntu2 in quantal amd64: universe/gnome/optional -> main
unity-webapps-common 2.4.6-0ubuntu2 in quantal armel: universe/gnome/optional -> main
unity-webapps-common 2.4.6-0ubuntu2 in quantal armhf: universe/gnome/optional -> main
unity-webapps-common 2.4.6-0ubuntu2 in quantal i386: universe/gnome/optional -> main
unity-webapps-common 2.4.6-0ubuntu2 in quantal powerpc: universe/gnome/optional -> main
webapps-greasemonkey 2.3.1-0ubuntu1 in quantal: universe/web -> main
xul-ext-websites-integration 2.3.1-0ubuntu1 in quantal amd64: universe/web/extra -> main
xul-ext-websites-integration 2.3.1-0ubuntu1 in quantal armel: universe/web/extra -> main
xul-ext-websites-integration 2.3.1-0ubuntu1 in quantal armhf: universe/web/extra -> main
xul-ext-websites-integration 2.3.1-0ubuntu1 in quantal i386: universe/web/extra -> main
xul-ext-websites-integration 2.3.1-0ubuntu1 in quantal powerpc: universe/web/extra -> main
Override [y|N]? y
23 publications overridden.