ubuntu patch 04_changelog broken, ill-defined scope, out-of-date

Bug #1053792 reported by Daniel Hartwig
0
Affects Status Importance Assigned to Milestone
aptitude (Ubuntu)
Expired
Undecided
Unassigned

Bug Description

ubuntu patch 04_changelog

This change is completely broken:

--- a/src/apt_options.cc
+++ b/src/apt_options.cc
- "http://cgi.debian.org/cgi-bin/get-changelog?package=%s"),
+ "http://changelogs.ubuntu.com/changelogs/pool/%s/%s/%s/%s_%s/changelog"),

It changes the meaning of the template parameter and introduces new parameters. There is nowhere in the patch where the consumer of this template is updated. The combination of these two points is bad, very bad, but ok in this case–by default–as the template in question has not been used since ancient history. None-the-less, the above change is absolutely wrong: should the use of this template be re-introduced Ubuntu users are at-risk of having broken values for it in their custom configuration.

Remove that change.

The patch also includes changes to interface strings which overlap the scope of 03_branding. Please move those changes there and keep 04_changelog exclusive to modifying which server is used.

--
Package: aptitude
Version: 0.6.8ubuntu1

Revision history for this message
Simon Quigley (tsimonq2) wrote :

Is this bug still valid?

I am asking because this is dates 2012...

Revision history for this message
Simon Quigley (tsimonq2) wrote :

*ated

Revision history for this message
Simon Quigley (tsimonq2) wrote :

*dated :P

Revision history for this message
Rolf Leggewie (r0lf) wrote :

ping Daniel for clarifcation

Changed in aptitude (Ubuntu):
status: New → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for aptitude (Ubuntu) because there has been no activity for 60 days.]

Changed in aptitude (Ubuntu):
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.