Mixxx

Out of bounds access in hss1394controller.cpp

Bug #1057782 reported by Markus Härer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Markus Härer
Mixxx 1.11.0

Bug Description

cppcheck found this bug:

[../mixxx/mixxx/src/controllers/midi/hss1394controller.cpp:170]: (error) Array 'data[2]' accessed at index 2, which is out of bounds.
[../mixxx/mixxx/src/controllers/midi/hss1394controller.cpp:175]: (error) Array 'data[2]' accessed at index 2, which is out of bounds.

I checked the code and it isn't a false positive.

A simple fix is attached.

Related branches

lp:mixxx/1.11
Revision history for this message
Markus Härer (markus-haerer) wrote :
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Thanks Markus -- committed the fix to the 1.11 release branch.

Changed in mixxx:
status: New → Fix Committed
assignee: nobody → Markus Härer (markus-haerer)
milestone: none → 1.11.0
importance: Undecided → Low
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6647

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.