Product Label Report - spacing issue and price precision issue

Bug #1064691 reported by Ray Carnes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
OpenERP R&D Addons Team 2

Bug Description

When printing product labels, they are printed with only one decimal place and without a space between the price and the currency (1.9USD instead of 1.95 USD). This problem can be replicated in OpenERP 6-1.1 and exists in the trunk code for 6.2/7.

1) Steps to reproduce the issue you have observed

A) Warehouse -> Products -> Products
B) Select or open a product
C) Click Products Labels on the action menu

2) The result you observed

The price was printed with one decimal place and without a space between the price and the currency.

3) The result you expected

The price printed with two decimal places and with a space between the price and the currency.

4) The platform you are using (and browser version, if relevant)

not believed to be relevant

5) The OpenERP version you are using (e.g. 6.1.1-20120910-233309), if possible including the specific revision (e.g. r.2824) if you use the source repositories.

revno 7001 of addons branch for OpenERP 6-1-1, but this same issue is in trunk for 6.2/7 at http://bazaar.launchpad.net/~openerp/openobject-addons/trunk/view/head:/product/report/product_label.xsl

See forum discussion at http://www.openerp.com/forum/post114458.html#p114458

Our fix is for comma thousand separator countries - North American, Australian, India, China, etc.

Tags: usability

Related branches

Revision history for this message
Ray Carnes (rcarnes) wrote :
description: updated
description: updated
Ray Carnes (rcarnes)
description: updated
Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Ray,

Would you please change your Rounding Factor = 0.01 for your currency.

Please go to Accounting>Configuration> Miscellaneous> Currency, Select your company currency and set the Rounding Factor = 0.01.

For your your 2nd issue related to space between currenry symbol and amount which is not valid.

So please change your Rounding Factor and check your rounding problem and notify us.

Thanks and waiting for your reply!

Changed in openobject-addons:
status: New → Incomplete
Revision history for this message
Ray Carnes (rcarnes) wrote :

Hi Amit,

I checked my currency configuration and it was already set to 0.010000

I just printed a product label from demo.openerp.com and you can see the problem there, even though (I assume) the currency rounding factor is set correctly there.

Hope that helps!

Ray.

Revision history for this message
Serpent Consulting Services (serpent-consulting-services) wrote :

Agreeing with Ray undoubtedly.

AFAIK, As the nature of xsl, if unspecified, it converts the float to string and hence you see troublesome values.

Plus, space is ofcourse a problem easily noticeable.

XML-xsl reporting does not seem to connect with any rounding stuff.

The patch from Ray is quite acceptable and we recommend Ray to create a merge proposal for 6.x/7.x !
(special thanks for preserve logic, learned something new)

Thanks,
Serpent Consulting Services.

Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Ray and Serpent,

I have faced the only space issue not the precision issue, I got the correct precision not only with two precision value but same for three precision.

I have attached the screen-shots for it, So would you please check it and let me know.

Thanks and waiting for your reply!

Revision history for this message
Amit Parik (amit-parik) wrote :
Revision history for this message
Amit Parik (amit-parik) wrote :
Revision history for this message
Serpent Consulting Services (serpent-consulting-services) wrote :

Dear Amit,

Did you try with 1.900? I suppose you would face an issue.

The concern is for x.00. The space is ofcourse an issue.

Throughout the whole business processes, we print space between amount and currency. So its worth considering a bug.

Thanks.

Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Serpent,

Thanks for your quick response.

I have faced the issue as per your comment#8, Yes it should be print 1.90 instead on 1.9 and ofcourse the space is an issue.

So I am confirming this issue.

Thanks again!

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 2 (openerp-dev-addons2)
importance: Undecided → Low
status: Incomplete → Confirmed
Amit Parik (amit-parik)
tags: added: usability
Farid Ghanchi (gfarid)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Farid Ghanchi (gfarid) wrote :

Hello,

I had fixed issue in this branch lp:~openerp-dev/openobject-addons/trunk-bug-1064691-ggh

Thanks...

Changed in openobject-addons:
status: In Progress → Invalid
status: Invalid → Fix Committed
Revision history for this message
Ray Carnes (rcarnes) wrote :

Thanks Farid!

Revision history for this message
Martin Trigaux (OpenERP) (mat-openerp) wrote :

Fix released in version 7. Thank you for reporting this issue.

Changed in openobject-addons:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.