Reporter Shared Folders Do Not Sort Logically

Bug #1065581 reported by Michael Peters
48
This bug affects 10 people
Affects Status Importance Assigned to Milestone
Evergreen
Confirmed
Low
Unassigned

Bug Description

Evergreen 2.2 > Master

The reporter "Shared Folders" interface uses a sort order that makes finding a particular user name's folder difficult. It would be best, in my opinion, to sort the user names alphabetically, rather than the seemingly random order now.

An example tree is below:

Templates
 ltpll-localadmin
  2010 Annual Report (EG-IN)
  2011 Annual Report (EG-IN)
  Derrick (EG-IN)
  Testing (EG-IN)
 aplsd-globaladmin
  APLS (APLS)
 ehinger
  APLS (APLS)
  Rich (APLS)
 rbryan
  APLS-Geneva (APLSD)
 adavidson
  Alice (EG-IN)

Optimal would be:

Templates
 adavidson
  Alice (EG-IN)
 aplsd-globaladmin
  APLS (APLS)
 ehinger
  APLS (APLS)
  Rich (APLS)
 ltpll-localadmin
  2010 Annual Report (EG-IN)
  2011 Annual Report (EG-IN)
  Derrick (EG-IN)
  Testing (EG-IN)
 rbryan
  APLS-Geneva (APLSD)

Revision history for this message
Michael Peters (mrpeters) wrote :

Screenshot for extra clarity

Revision history for this message
Ben Shum (bshum) wrote :

Marking confirmed. It would be nice if folders were also sorted alphabetically for clarity.

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Ruth Frasur Davis (redavis) wrote :

This is not necessarily a critical issue, but sort order directly affects workflows for users. Even if there is not a patch for 2.2, this should be addressed in later versions.

Revision history for this message
Michael Peters (mrpeters) wrote :

This is probably a bitesize bug for someone familiar with Perl. I think Open-ILS/src/perlmods/lib/OpenILS/Application/Reporter.pm is the starting point.

tags: added: bitesize
Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbej)
Changed in evergreen:
status: Confirmed → In Progress
Changed in evergreen:
assignee: Jane Sandberg (sandbej) → nobody
status: In Progress → Confirmed
tags: removed: reporter
tags: removed: order username
Revision history for this message
Geoff Sams (gsams) wrote :

I took a look at this today starting from Reporter.pm, which looks like it simply needs one change on line 79 from:

         order_by => { $class => 'name ASC'}

To:

         order_by => { $class => ['username ASC', 'name ASC']}

However, username isn't a thing and I am not knowledgeable in how to reference username for the purposes of sorting within this file!

The current sort order isn't random however, it bases the order of user folders on the sort order of their respective folders. For instance:

zUser15
  !folder1
  !folder2
  !folder4
  dailies
  monthlys
  ztesting
zUser01
  !folder3
  afolder
  2folders
aUser00
  abcfolder
  abcfolder2
  abcfolder3
dUser15
  buttons
  hats

It places zUser15 first because they have more high sorting folders that zUser01 and so on. If 'owner ASC' is placed in the sort it sorts by the id of the user which doesn't properly resolve this issue.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.