graphics/minimum_resolution test has confusing text
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox |
Fix Released
|
Medium
|
Brendan Donegan |
Bug Description
During a run, I noticed that the minimum resolution test now says this on passing:
Expected monitor dimensions: 800 x 600 Detected monitor dimensions: 1920 x 1080
I would assume that on a failure, it would say something like this:
Expected monitor dimensions: 800 x 600 Detected monitor dimensions: 640 x 480
Semantically, BOTH of those tests could be viewed as a failure, as "Expected" indicates that the resolution should have been 800x600.
It would be more clear to the tester if the text reflected Pass or Fail more accurately. This could be as simple as changing the string to something like this:
Minimum acceptable resolution: 800x600. Detected resolution: 1920 x 1080
Also, "monitor dimensions" is a vague term. In my mind, that's the size of the panel itself (e.g. 22", 24") and resolution is a fairly standard descriptive term for the pixel size of a display. Plus, "Monitor" implies an external device, while display could be either a builtin screen on a laptop or an externally connected LCD or CRT monitor.
Related branches
- Marc Tardif (community): Approve
-
Diff: 25 lines (+4/-2)2 files modifieddebian/changelog (+2/-0)
scripts/resolution_test (+2/-2)
Changed in checkbox: | |
importance: | Undecided → Low |
Changed in checkbox: | |
status: | New → Triaged |
importance: | Low → Medium |
assignee: | nobody → Brendan Donegan (brendan-donegan) |
Changed in checkbox: | |
status: | Triaged → In Progress |
Changed in checkbox: | |
status: | In Progress → Fix Committed |
status: | Fix Committed → Fix Released |