database/productrelease.py has duplicate lines causing two queries

Bug #107077 reported by Brad Crittenden
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
Brad Crittenden

Bug Description

In ProductRelease the following duplicated code appears:

    files = SQLMultipleJoin('ProductReleaseFile', joinColumn='productrelease')

    files = SQLMultipleJoin('ProductReleaseFile', joinColumn='productrelease')

One of the lines needs to be removed to avoid a redundant query.

Brad Crittenden (bac)
Changed in launchpad:
assignee: nobody → bradcrittenden
Changed in launchpad:
status: Unconfirmed → Confirmed
Revision history for this message
James Henstridge (jamesh) wrote :

This is a bug, but it doesn't cause multiple queries. Simply calling SQLMultipleJoin() does not cause a query to occur -- using "instance.files" afterwards does though.

Brad Crittenden (bac)
Changed in launchpad:
status: Confirmed → Fix Committed
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.