audio_test --audio and --spectrum options trigger error about lack of --verbose option
Bug #1070829 reported by
Brendan Donegan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Checkbox |
Fix Released
|
Medium
|
Daniel Manrique | ||
Bug Description
It seems at some point the --verbose option was removed from this script, but it is still referred to in the code. Either the option should be restored or the code that references it should be removed.
Related branches
lp:~roadmr/checkbox/audio-verbose-fix
- Zygmunt Krynicki (community): Approve
-
Diff: 44 lines (+5/-6)2 files modifieddebian/changelog (+2/-1)
scripts/audio_test (+3/-5)
Revision history for this message
| Daniel Manrique (roadmr) wrote | #1 |
| Changed in checkbox: | |
| importance: | Undecided → Medium |
| status: | New → In Progress |
| assignee: | nobody → Daniel Manrique (roadmr) |
Revision history for this message
| Daniel Manrique (roadmr) wrote | #2 |
| Changed in checkbox: | |
| status: | In Progress → Fix Committed |
| Changed in checkbox: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I removed it because it made little sense. The default behavior was quiet, and -verbose enabled some debugging, but I ran into trouble with the logging module and the easiest solution was to default to a slightly-verbose behavior, with a --debug option for very detailed output, and a --quiet option for quiet (only errors and exit code) behavior.
The fix here is to change the job definitions to not use the --verbose option. Apologies for not doing that when I committed the actual change to the test.