TestContext is broken when a previous version of the runner is used alongside a new version of the framework
Bug #1071714 reported by
Simone Busoli
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| NUnit V2 |
Fix Released
|
Critical
|
Simone Busoli | ||
| NUnitLite |
Fix Released
|
High
|
Charlie Poole | ||
Bug Description
With 2.6.2 support for flowing TestContext across threads, mainly for supporting async tests was introduced.
The way it was implemented broke the scenario (regardless of whether async tests or not) in which a previous runner along with the 2.6.2 framework was used.
We should support backwards and forward compatibility if possible.
| Changed in nunitv2: | |
| status: | New → In Progress |
| assignee: | nobody → Simone Busoli (simone.busoli) |
| description: | updated |
Revision history for this message
| Simone Busoli (simone.busoli) wrote | #1 |
| Changed in nunitv2: | |
| status: | In Progress → Fix Committed |
| Changed in nunitv2: | |
| importance: | Undecided → Critical |
| milestone: | none → 2.6.3 |
Revision history for this message
| Charlie Poole (charlie.poole) wrote | #2 |
| Changed in nunitlite: | |
| milestone: | none → 0.9 |
| Changed in nunitlite: | |
| assignee: | nobody → Charlie Poole (charlie.poole) |
| importance: | Undecided → High |
| status: | New → Fix Committed |
| Changed in nunitlite: | |
| status: | Fix Committed → Fix Released |
| Changed in nunitv2: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
The fix will supports these scenarios, with actors core and fx and in flavors old (<= 2.6.1), 2.6.2, and new (> 2.6.2):
1. old core - fx 2.6.2 is NOK, as above
2. old core - new fx is OK: core puts the data in the illogical context and fx is able to retrieve it from there. Of course the feature of having the ContextDictionary flow across threads is not there but this is obvious
3. core 2.6.2 - old fx is OK, as above
4. core 2.6.2 - new fx is OK: core puts data in the logical context, fx will pick it up from there
5. new core - old fx is OK: core puts data in the logical context, fx will pick it up from there
6. new core - fx 2.6.2 is OK: core puts data in the logical context, fx will pick it up from there