Move to ThreadGroups makes deletes block for pending WaitConditions

Bug #1078064 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Steven Hardy
Grizzly
Fix Released
High
Steven Hardy

Bug Description

8135da2fb42a8f34d530369dde6f3ddd216ffd97 breaks the fix I introduced in b0661fd to cancel pending waitcondition threads when a stack is deleted, and infact makes the situation worse than it was before as now we block until the waitcondition expires, meaning the delete times out and returns an error to the user.

Steps to reproduce:
1 - Launch a template which has a waitcondition
2 - Delete while the waitcondition is yet to complete
3 - Observe that the delete blocks until either the waitcondition completes or the request to the engine times out

Steven Hardy (shardy)
Changed in heat:
importance: Undecided → High
Revision history for this message
Steven Hardy (shardy) wrote :

This needs to be fixed in openstack-common, fix posted:

https://review.openstack.org/15906

Also, we probably don't need to wait() after the stop() in engine/service.py, since this will just raise a greenlet.GreenletExit exception

Changed in heat:
status: New → Triaged
assignee: nobody → Steven Hardy (shardy)
Revision history for this message
Steven Hardy (shardy) wrote :

Fix removing the wait() : https://review.openstack.org/15908

Angus Salkeld (asalkeld)
Changed in heat:
milestone: none → grizzly-1
Revision history for this message
Steven Hardy (shardy) wrote :

Fixes merged:

9096b58 heat align openstack/common with latest oslo-incubator
75fc3c9 heat engine : Don't wait() for killed greenthreads

Closing

Changed in heat:
status: Triaged → Fix Committed
Revision history for this message
Steven Hardy (shardy) wrote :

s/Closing/Moving to Fix Committed/

Angus Salkeld (asalkeld)
Changed in heat:
milestone: grizzly-1 → grizzly-2
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.