It is possible to write to a plugin in compizconfig that has no associated gsettings schema
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Compiz |
Fix Released
|
Medium
|
Sam Spilsbury | ||
| compiz (Ubuntu) |
Fix Released
|
Medium
|
Sam Spilsbury | ||
Bug Description
It seems possible to write plugin settings implicitly in compizconfig where there is no settings schema. A situation like this can arise:
* integrated settings updated
* read in new integrated setting value
* disable integration temporarily
* call ccsSetValue - that puts it back into the write queue
* writeSetting called -> integrated disabled so it writes the original key
* attempts to touch a key that doesn't exist
21:46 < mhr3> smspillaz_, so yea didn't help, i'm getting error from gsettings
that it can't find org.compiz.
While we shouldn't even be doing that in the first place, the lesser evil is probably to not abort whenever an improper use of compizconfig occurrs, as that will crash the desktop or gsd.
Related branches
- Daniel van Vugt: Approve
- Michal Hruby (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 279 lines (+153/-13)5 files modifiedcompizconfig/gsettings/gsettings_backend_shared/ccs_gsettings_interface_wrapper.c (+98/-10)
compizconfig/gsettings/gsettings_backend_shared/gsettings_util.c (+12/-2)
compizconfig/gsettings/gsettings_backend_shared/gsettings_util.h (+1/-1)
compizconfig/gsettings/tests/test_gsettings_tests.cpp (+11/-0)
compizconfig/gsettings/tests/test_gsettings_wrapper.cpp (+31/-0)
| Changed in compiz: | |
| status: | New → In Progress |
| importance: | Undecided → Medium |
| assignee: | nobody → Sam Spilsbury (smspillaz) |
| milestone: | none → 0.9.9.0 |
| Changed in compiz: | |
| status: | In Progress → Fix Committed |
| Changed in compiz (Ubuntu): | |
| assignee: | nobody → Sam Spilsbury (smspillaz) |
| importance: | Undecided → Medium |
| status: | New → Fix Committed |
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in compiz (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Changed in compiz: | |
| status: | Fix Committed → Fix Released |
This bug was fixed in the package compiz - 1:0.9.9~
---------------
compiz (1:0.9.
[ Michael Terry ]
* debian/control:
- Update Vcs-Bzr
* debian/
- Fix to apply
* Automatic snapshot from revision 3451 (bootstrap)
- Fix crash from writing to static memory (LP: #1065814)
- Fix maximized windows changing workspaces (LP: #1071791)
- Respect Zoom Factor setting (LP: #1066187)
- Respect Show Window Title setting (LP: #1009999)
- Restore text background transparency (LP: #1042132)
- Restore screenshot selection rectangle transparency (LP: #1047788)
- Restore top and bottom cube transparency (LP: #1048272)
- Fix scaleaddon window highlighting being solid (LP #1068503)
- Make resize hint overlay disappear when changing edges (LP: #839602)
- Preserve grid IDs during drag (LP: #1067812, LP: #1048855)
- Save current display before doing snap preview (LP: #1068173)
- Ignore inactive keybindings (LP: #1053280)
- Handle <primary> in keyboard shortcuts (LP: #936840)
- Make sure showdesktop plugin is loaded after unityshell (LP: #1067534)
- Fix grid build failure (LP: #1067577)
- Fix Jenkins test failures (LP: #1058577)
- Don't allow duplicate static symbols when linking (LP: #1067964)
- Make external templates C++0x compatible (LP: #1067598)
- Make sure to initialize class members (LP: #1033877)
- Don't duplicate templates in plugins (LP: #1066793, LP: #1066803,
LP: #1066804, LP: #1066805, LP: #1066799, LP: #1066796,
LP: #1066795, LP: #1066798, LP: #1067218, LP: #1067219)
- Don't needlessly set gsettings keys (LP: #1064791)
- Remove unused code (LP: #1037142, LP: #1067234)
- Fix syntax highlighting for trunk xml files (LP: #1066823)
- Fix documentation for building with python2 (LP: #1070211)
[ Stephen M. Webb ]
* Windows open below panel and launcher, grid does not work at all,
window animations missing, and general plugin chaos if built on
raring (cmake >= 2.8.10) (LP: #1085581)
[ Iven Hsu ]
* KDE Appmenu doesn't work with compiz decorators (LP: #1082265)
* compiz 0.9.8.6 fails to build from source in KDE4-window-
with latest KDE 4.10 beta (LP: #1082152)
* kde4-window-
(LP: #1050776)
[ sampo555 ]
* Grid: Window management - resize preview does not show when moving a
window from the semi-maximised state to the maximised state in a
single action (LP: #1071689)
[ Timo Jyrinki ]
* HTML5 video in Firefox continues to tear (LP: #1086337)
[ MC Return ]
* Workspacenames Plug-in: Wishlist: Default Appearance values not
ideal (LP: #1075600)
* Resizeinfo Plug-in: No possibility to change the color and
transparency of the rounded background outline (LP: #1070297)
* Resizeinfo Plug-in: Gradient color 2 and 3 settings are ignored and
no background gradient is rendered (LP: #1070233)
* Expo animations "Fade + Zoom" & "Vortex" result in a black screen
(LP: #875311)
* Workspacenames Plug-in: Wishlist: No default values...