[Trunk] Bom Structure Display

Hello,

It has been Fixed in https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1082454-dhr

revision-id: <email address hidden>

revno: 8173

Thanks,
Dharti Ratani

Just fyi. The fix has no effect and the bug is not fixed as of revno: 8199.

Just fyi, see attached for tree view.

Expected: A list of the first level components in the BOM. All components with a sub-BOM have a triangle next to them. You click on the triangle to expand the BOM branch. You can browse the structure.

> I think that current trunk works as you expect, could you confirm if so?

trunk_1309.runbot.openerp.com

I tested trunk_1309 and the results were as described in the bug. No change. Not fixed.

Works for me in 7.0

When you say "Works for me" do you mean that you agree with the bug report
or that you think there is no bug?

I checked with the latest runbot this morning and the bug is still present.
http://7-0-2590.runbot.openerp.com

I repeat: Clicking on the "Bill of Materials Structure" gets you only the
first level of the BOM. We're supposed to get a tree view where multiple
levels are visible at the same time.

On Tue, Jan 29, 2013 at 10:48 AM, etsinko <email address hidden>wrote:

> Works for me in 7.0
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1082454
>
> Title:
> [Trunk] Bom Sturcture Display
>
> Status in OpenERP Addons (modules):
> In Progress
>
> Bug description:
> [6.2dev-20121122-000101]
>
> Summary: The "BOM Structure" view is absent.
>
> Load the demo data. Go to Manufacturing/Bill of Materials/[PC-DEM]
> In the "More" menu, select "Bill of Materials Structure".
>
> Expected: A list of the first level components in the BOM. All
> components with a sub-BOM have a triangle next to them. You click on
> the triangle to expand the BOM branch. You can browse the structure.
>
> Actual: A list of the first level components in the BOM. Clicking on a
> component takes you to it's BOM.
>
> Settings: False = Allow several bill of materials per products using
> properties
>
> The "BOM Structure" function must result in a tree view. Or else it is
> meaningless and is identical to the regular BOM view.
>
> NB. I'm not talking about the Print/PDF of the BOM structure.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-addons/+bug/1082454/+subscriptions
>

Hi Gilles,
When I say "Works for me", I agree with the bug report and the fact that it applies to the [7.0] branch as well.
Also I mean that the fix proposed by Dharti fixes this issue in [7.0].
Here are the screenshots before and after applying the patch and reinstalling module 'mrp'.
Load the demo data. Go to Manufacturing/Bill of Materials/[PC-DEM]
In the "More" menu, select "Bill of Materials Structure".

I'm not familiar with the process of how a fix gets incorporated. Since
this fix is not present in the latest builds I've seen, can you tell me
where it's at and what steps are left before it is final?

Aren't the runbot builds representative of the the most latest?

On Wed, Jan 30, 2013 at 10:27 AM, etsinko <email address hidden>wrote:

> ** Attachment added: "After"
>
> https://bugs.launchpad.net/openobject-addons/+bug/1082454/+attachment/3507594/+files/after.png
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1082454
>
> Title:
> [Trunk] Bom Sturcture Display
>
> Status in OpenERP Addons (modules):
> In Progress
>
> Bug description:
> [6.2dev-20121122-000101]
>
> Summary: The "BOM Structure" view is absent.
>
> Load the demo data. Go to Manufacturing/Bill of Materials/[PC-DEM]
> In the "More" menu, select "Bill of Materials Structure".
>
> Expected: A list of the first level components in the BOM. All
> components with a sub-BOM have a triangle next to them. You click on
> the triangle to expand the BOM branch. You can browse the structure.
>
> Actual: A list of the first level components in the BOM. Clicking on a
> component takes you to it's BOM.
>
> Settings: False = Allow several bill of materials per products using
> properties
>
> The "BOM Structure" function must result in a tree view. Or else it is
> meaningless and is identical to the regular BOM view.
>
> NB. I'm not talking about the Print/PDF of the BOM structure.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-addons/+bug/1082454/+subscriptions
>

I don't think this fix has been incorporated yet as the bug's status is 'In Progress'. So I think it has to be reviewed and incorporated into [trunk]
To fix this issue I just edited addons/mrp/mrp_view.xml and added one line as proposed in Dharti's change:
https://i124500952.restricted.launchpadlibrarian.net/124500952/2347ea0c-3ae4-11e2-b3c6-002481e91f22.txt?token=1d1b77a6a09e2426552e68a9cd8b1557

Thanks.

On Wed, Jan 30, 2013 at 11:32 AM, etsinko <email address hidden>wrote:

> I don't think this fix has been incorporated yet as the bug's status is
> 'In Progress'. So I think it has to be reviewed and incorporated into
> [trunk]
> To fix this issue I just edited addons/mrp/mrp_view.xml and added one line
> as proposed in Dharti's change:
>
> https://i124500952.restricted.launchpadlibrarian.net/124500952/2347ea0c-3ae4-11e2-b3c6-002481e91f22.txt?token=1d1b77a6a09e2426552e68a9cd8b1557
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1082454
>
> Title:
> [Trunk] Bom Sturcture Display
>
> Status in OpenERP Addons (modules):
> In Progress
>
> Bug description:
> [6.2dev-20121122-000101]
>
> Summary: The "BOM Structure" view is absent.
>
> Load the demo data. Go to Manufacturing/Bill of Materials/[PC-DEM]
> In the "More" menu, select "Bill of Materials Structure".
>
> Expected: A list of the first level components in the BOM. All
> components with a sub-BOM have a triangle next to them. You click on
> the triangle to expand the BOM branch. You can browse the structure.
>
> Actual: A list of the first level components in the BOM. Clicking on a
> component takes you to it's BOM.
>
> Settings: False = Allow several bill of materials per products using
> properties
>
> The "BOM Structure" function must result in a tree view. Or else it is
> meaningless and is identical to the regular BOM view.
>
> NB. I'm not talking about the Print/PDF of the BOM structure.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-addons/+bug/1082454/+subscriptions
>

Fix landed in trunk at revision 8762 (revid <email address hidden>).