Web-Client 7.0 calls write with blank vals, when you click on any buton in form

Bug #1093781 reported by Mohammed Shekha(Open ERP)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Web (MOVED TO GITHUB)
Fix Released
Medium
OpenERP R&D Web Team

Bug Description

Hello,

Steps :- Open any form view which contains buttons, now without making form dirty just click on button so now according to architecture web-client will first saves the form(calls create/write based on whether form contains id or not),, reload the record and then will load action but here we have not touched a field still web-client will call write with vals={}, this should not happen as there is no value to write than why it should call write.

Reason :- when one click on button we did form force fully dirty by setting force_dirty=true, so it will forcefully call write whether form is dirty or not.

After analysis I found that the logic of force_dirty is for reloading one2many record when buttons is clicked, but this is not a proper logic to forcefully reload record for one2many, please refer revision 2341 of Web-Client 6.1 where same thing did to reload record on button click.

Thanks.

Related branches

Anand (anand-m-patel)
Changed in openerp-web:
status: New → Confirmed
Amit Parik (amit-parik)
Changed in openerp-web:
assignee: nobody → OpenERP R&D Web Team (openerp-dev-web)
importance: Undecided → Medium
Revision history for this message
Nicolas Vanhoren (OpenERP) (niv-openerp) wrote :

I was very close to mark this report as invalid, because you don't really report a bug, just a behavior that doesn't seem to please you. There is a really problem reported here: https://bugs.launchpad.net/openerp-web/+bug/965326 .

Changed in openerp-web:
status: Confirmed → In Progress
Revision history for this message
Nicolas Vanhoren (OpenERP) (niv-openerp) wrote :

Ok, it seems like the force_dirty attribute introduced in the bug fix for 965326 is not useful anymore, due to other features I created since then (recursive_reload), so I removed it in revision 3672.

Anyway there seems to be other problems related to buttons in o2m, I'll open a bug report about that.

Changed in openerp-web:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.