OpenStack Compute (nova)

failure to inject user specified files does not cause instance startup to fail

Bug #1095744 reported by Pádraig Brady
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Pádraig Brady
OpenStack Compute (nova) 2013.1 "grizzly"

Bug Description

In Essex if the user asked for files to be injected on instance startup,
failing to do so would cause the instance start to fail.
This was changed inadvertently in Folsom with:
https://review.openstack.org/#/c/9470/

We should probably revert to the old behavior?
At least we should make it easy in the code
to select which items result in errors and which only in warnings.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/18900

Changed in nova:
assignee: nobody → Pádraig Brady (p-draigbrady)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/18900
Committed: http://github.com/openstack/nova/commit/e91e6c07d9e34b79114ecac29b3669084e331f5a
Submitter: Jenkins
Branch: master

commit e91e6c07d9e34b79114ecac29b3669084e331f5a
Author: Pádraig Brady <email address hidden>
Date: Thu Jan 3 02:59:34 2013 +0000

    ensure failure to inject user files results in startup error

    This was the case in Essex but was inadvertantly changed in:
    folsom-2-95-g0d166ca.

    * nova/virt/disk/api.py: Refactor to allow specifying
    mandatory injection items, that result in an exception
    on failure to inject.
    * nova/virt/libvirt/driver.py: Specify that user 'files'
    are mandatory items and thus result in VM startup failure
    unless injected successfully.
    * nova/tests/test_virt_disk.py: A new test for the
    separate warning and error cases.

    Fixes bug: 1095744
    Change-Id: Idab5c4294c1cb52098ce44a7aae957a44fb2674f

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.