report_webkit translation_call does not pass proper name

Bug #1098602 reported by Niels Huylebroeck
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
OpenERP Publisher's Warranty Team

Bug Description

We are having issues translating webkit reports correctly.

If a certain translateable term happens to be the same src value as on another report (both webkit and non-webkit reports) the resulting translation on a webkit report uses the first translation found (which is highly likely to be from the other report)

This is not logical, think about the "State" variable issues we had before, how State should be translated is highly dependant on the report and context.

Cause: not passing a proper name to ir_translation._get_source(...)
http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/view/head:/report_webkit/webkit_report.py#L194

Suggestion: Instead of passing the template name (or path which can be hard to determine) I would suggest you use the service name this is guaranteed to be unique after all. While this is indeed quite a big change it should be possible to make it backwards compatible by first checking and if no result was found only then try the new method of searching on service name.

Tags: maintenance

Related branches

Amit Parik (amit-parik)
Changed in openobject-addons:
assignee: nobody → Nicolas Bessi - Camptocamp (nbessi-c2c)
Changed in openobject-addons:
assignee: Nicolas Bessi - Camptocamp (nbessi-c2c) → OpenERP Publisher's Warranty Team (openerp-opw)
tags: added: maintenance
Changed in openobject-addons:
importance: Undecided → Low
status: New → Fix Committed
Revision history for this message
Ravi Gohil (OpenERP) (rgo-openerp) wrote :

Hi,

This issue has been fixed for V6.1 in,
Branch: lp:~openerp-dev/openobject-addons/6.1-opw-586086-rgo
Rev Id: <email address hidden>
Rev #: 7154

and, for V7.0,
Branch: lp:~openerp-dev/openobject-addons/7.0-opw-586086-rgo
Rev Id: <email address hidden>
Rev #: 8706

The branches are under review of our experts, once it gets reviewed, it will be merge with main stable branch.

Thanks.

Revision history for this message
Martin Trigaux (OpenERP) (mat-openerp) wrote :

Hello,

Sorry for the long wait for this one.
I merged this into 6.1 and 7.0 with an addition. When there is no translation found with the name, fallback on the one with None. This prevent backward incompatibilities.

Thanks for reporting

addons 6.1
revno: 7220
revision-id: <email address hidden>

addons 7.0
revno: 9222 [merge]
revision-id: <email address hidden>

Changed in openobject-addons:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.