report_webkit translation_call does not pass proper name
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Odoo Addons (MOVED TO GITHUB) |
Fix Released
|
Low
|
OpenERP Publisher's Warranty Team |
Bug Description
We are having issues translating webkit reports correctly.
If a certain translateable term happens to be the same src value as on another report (both webkit and non-webkit reports) the resulting translation on a webkit report uses the first translation found (which is highly likely to be from the other report)
This is not logical, think about the "State" variable issues we had before, how State should be translated is highly dependant on the report and context.
Cause: not passing a proper name to ir_translation.
http://
Suggestion: Instead of passing the template name (or path which can be hard to determine) I would suggest you use the service name this is guaranteed to be unique after all. While this is indeed quite a big change it should be possible to make it backwards compatible by first checking and if no result was found only then try the new method of searching on service name.
Related branches
- Naresh(OpenERP) (community): Approve
- Niels Huylebroeck (community): Approve
-
Diff: 14 lines (+2/-1)1 file modifiedreport_webkit/webkit_report.py (+2/-1)
- Niels Huylebroeck (community): Approve
- Naresh(OpenERP): Pending requested
-
Diff: 14 lines (+2/-1)1 file modifiedreport_webkit/webkit_report.py (+2/-1)
Changed in openobject-addons: | |
assignee: | nobody → Nicolas Bessi - Camptocamp (nbessi-c2c) |
Changed in openobject-addons: | |
assignee: | Nicolas Bessi - Camptocamp (nbessi-c2c) → OpenERP Publisher's Warranty Team (openerp-opw) |
tags: | added: maintenance |
Changed in openobject-addons: | |
importance: | Undecided → Low |
status: | New → Fix Committed |
Hi,
This issue has been fixed for V6.1 in,
Branch: lp:~openerp-dev/openobject-addons/6.1-opw-586086-rgo
Rev Id: <email address hidden>
Rev #: 7154
and, for V7.0,
Branch: lp:~openerp-dev/openobject-addons/7.0-opw-586086-rgo
Rev Id: <email address hidden>
Rev #: 8706
The branches are under review of our experts, once it gets reviewed, it will be merge with main stable branch.
Thanks.