trunk: live preview for extensions and filters broken (inkscape hangs, then crashes)

Bug #1103248 reported by su_v
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
High
Unassigned

Bug Description

Revision 12053 breaks live preview for extensions and predefined custom filters:
Filters:
- live preview can be toggled on, but inkscape hangs when it is toggled off again (e.g. 'Color > Lightness-Contrast' applied on a group of paths)
Extensions:
- inkscape hangs when toggling live preview on (e.g. 'Render > Gears…' in new document)
- inkscape crashes when live-previewing an extension modifying a selected path (e.g. 'Generate from Path > Motion')

Works as expected with r12052, fails to work with r12053 and r12054.
Reproduced on
- OS X 10.7.4 with X11- and Quartz-based builds (glib 2.32.4, glib 2.34.3)
- Ubuntu 12.10 (64bit, VM, glib 2.34.1)

Crash:

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_PROTECTION_FAILURE at address: 0x00007fff5f3ffff8
0x000000010009ab70 in SPDocument::getObjectById (this=0x10c3c0f00, id=@0x10c3ffdd8) at document.cpp:865
865 return getObjectById( id );
(gdb) bt
#0 0x000000010009ab70 in SPDocument::getObjectById (this=0x10c3c0f00, id=@0x10c3ffdd8) at document.cpp:865
#1 0x000000010009ab75 in SPDocument::getObjectById (this=0x10c3c0f00, id=@0x10c3ffdd8) at document.cpp:865
<last line repeated many times>

su_v (suv-lp)
description: updated
Revision history for this message
jazzynico (jazzynico) wrote :

Confirmed on Windows XP, Inkscape trunk revision 12054.
Inkscape doesn't crash, bug hangs when toggling live preview.

Changed in inkscape:
milestone: none → 0.49
status: New → Triaged
Revision history for this message
jazzynico (jazzynico) wrote :

Also hangs when using the Object>Symbols dialog (reproduced when testing Bug #1103239).

Revision history for this message
su_v (suv-lp) wrote :

@Kris - could you take a closer look, or revert the changes from r12053 for now?

Revision history for this message
Kris (kris-degussem) wrote :

Reverted revision 12053 in revision 12058.
Sorry for the unconvenience.
It should not have been a problem. I noticed that when browsing the code that sometimes there are two alternative functions, where one alternative accepts string classes and the other alternative accepts the c-string. In case you start which a string class string it would be better to use the string class alternative as opposed to converting first to c-string. (general idea that string class usage is better) Maybe there is some underlying undetected problem aware, though I'd consider this bug as closed by reverting r12053.

Changed in inkscape:
status: Triaged → Fix Released
milestone: 0.49 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.