Ambiguous URLs in search (lp: or cs:)
Bug #1118351 reported by
Roger Peppe
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| charmworld |
Fix Released
|
Medium
|
Aaron Bentley | ||
Bug Description
For example: http://
The charms are printed in the form:
~clint-
but to be valid charm URLs, they should look like this:
cs:
Note the extra cs: prefix and the colon that should be a slash.
Related branches
lp:~abentley/charmworld/label-to-short-url
- Richard Harding (community): Approve
-
Diff: 220 lines (+25/-24)13 files modifiedcharmworld/graph.py (+7/-7)
charmworld/templates/charm-proof-errors.pt (+1/-1)
charmworld/templates/charm.pt (+1/-1)
charmworld/templates/config.pt (+2/-2)
charmworld/templates/hook.pt (+1/-1)
charmworld/templates/interface-collection.pt (+2/-2)
charmworld/templates/recent.pt (+1/-1)
charmworld/templates/search.pt (+1/-1)
charmworld/views/charms.py (+1/-1)
charmworld/views/experiment.py (+2/-1)
charmworld/views/feeds.py (+2/-2)
charmworld/views/tests/test_charms.py (+2/-2)
charmworld/views/tests/test_feeds.py (+2/-2)
| summary: |
- Charm URLs shown with invalid URLs in search + Ambiguous URLs in search (lp: or cs:) |
| Changed in charmworld: | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
Revision history for this message
| Roger Peppe (rogpeppe) wrote | #1 |
| tags: | added: ui |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #2 |
| Changed in charmworld: | |
| assignee: | nobody → Aaron Bentley (abentley) |
| status: | Triaged → In Progress |
| Changed in charmworld: | |
| status: | In Progress → Fix Committed |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
the most important thing for me is not the cs prefix
which is easy enough to infer (we're used to adding prefixes
in URLs), but the ":", which is not obvious.
the colon means the URLs are more than just ambiguous;
they're wrong.
but perhaps py juju accepts URLs in that form?