BranchView.landing_candidates needs preloading
Bug #1131407 reported by
Laura Czajkowski
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Steve Kowalik |
Related branches
lp:~stevenk/launchpad/preload-landing_candidates
- William Grant: Approve (code)
-
Diff: 502 lines (+80/-95)3 files modifiedlib/lp/code/browser/branch.py (+8/-1)
lib/lp/code/browser/tests/test_branch.py (+69/-93)
lib/lp/code/configure.zcml (+3/-1)
Changed in auditor: | |
status: | New → Triaged |
importance: | Undecided → Critical |
tags: | added: oops |
Changed in launchpad: | |
assignee: | nobody → Steve Kowalik (stevenk) |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Branch:+index can time out if there are hundreds of unmerged merges proposed into the branch, as BranchView. landing_ candidates checks launchpad.View on each MP without preloading the related branches. A subset of preloadDataForBMPs is probably useful here.