List of workers in building window not updating properly
Bug #1132469 reported by
Hans Joachim Desserud
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Low
|
cghislai | ||
Bug Description
Steps to reproduce:
1. Build some building and wait for it to finish.
2. Open the building window and if necessary switch to the workers tab.
3. Verify the worker is listed as "coming"
4. Keep the window open and wait for the worker to enter the building.
Expected result:
Upon entering, the window is updated, listing the worker as present.
Actual result:
Unless you hover the cursor over some part of the window or otherwise do something no update will be triggered.
This sounds suspisciously similar to bug 726139 if you ask me, so a similar fix might work here too.
Widelands bzr r6515.
Related branches
lp:~widelands-dev/widelands/ui_improvments
- SirVer: Approve
-
Diff: 1269 lines (+309/-216)36 files modifiedsrc/chat.h (+6/-0)
src/constants.h (+1/-1)
src/debugconsole.cc (+4/-0)
src/gamecontroller.cc (+31/-3)
src/logic/building.cc (+6/-0)
src/logic/building.h (+5/-0)
src/logic/production_program.cc (+2/-2)
src/logic/productionsite.cc (+1/-1)
src/logic/trainingsite.cc (+1/-6)
src/network/internet_gaming.cc (+8/-1)
src/network/internet_gaming.h (+3/-0)
src/network/netclient.cc (+9/-0)
src/network/netclient.h (+1/-0)
src/network/nethost.cc (+7/-0)
src/save_handler.cc (+10/-2)
src/timestring.cc (+15/-0)
src/timestring.h (+5/-0)
src/ui_basic/progressbar.cc (+9/-12)
src/ui_basic/table.cc (+11/-22)
src/ui_fsmenu/loadgame.cc (+3/-8)
src/ui_fsmenu/loadreplay.cc (+3/-8)
src/ui_fsmenu/mapselect.cc (+3/-3)
src/wlapplication.cc (+7/-5)
src/wui/building_ui.cc (+8/-1)
src/wui/buildingwindow.cc (+5/-46)
src/wui/buildingwindow.h (+0/-1)
src/wui/fieldaction.cc (+1/-43)
src/wui/game_main_menu_save_game.cc (+20/-13)
src/wui/game_main_menu_save_game.h (+1/-1)
src/wui/game_message_menu.cc (+5/-13)
src/wui/interactive_base.cc (+64/-0)
src/wui/interactive_base.h (+3/-0)
src/wui/interactive_player.cc (+13/-10)
src/wui/interactive_player.h (+3/-0)
src/wui/productionsitewindow.cc (+34/-13)
src/wui/productionsitewindow.h (+1/-1)
| Changed in widelands: | |
| status: | New → Confirmed |
Revision history for this message
| SirVer (sirver) wrote | #1 |
| Changed in widelands: | |
| status: | Confirmed → Triaged |
| Changed in widelands: | |
| assignee: | nobody → cghislai (charlyghislain) |
| Changed in widelands: | |
| status: | Triaged → In Progress |
Revision history for this message
| Hans Joachim Desserud (hjd) wrote | #2 |
| Changed in widelands: | |
| milestone: | none → build18-rc1 |
| status: | In Progress → Fix Committed |
Revision history for this message
| SirVer (sirver) wrote | #3 |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
We recently had a fix for a similar problem, but for the warelists not being updated properly. A similar solution should be applied here (essentially, making the building an Observable with a boost::signal (that might need to be mutable) which is called whenever its state changes - the Window will then register with this signal and redraw when it is triggered.