Please sponsor axel upload

Bug #114380 reported by Oumar Aziz OUATTARA
2
Affects Status Importance Assigned to Milestone
axel (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 affects ubuntu/axel
 subscribe ubuntu-universe-sponsors

diff -u axel-1.0b/debian/changelog axel-1.0b/debian/changelog
- --- axel-1.0b/debian/changelog
+++ axel-1.0b/debian/changelog
@@ -1,3 +1,10 @@
+axel (1.0b-1.1ubuntu1) feisty; urgency=low
+
+ * Fixed non existing thread killing
+ * Error messages were never showed (cause they were misplaced)
+
+ -- Ouattara Oumar Aziz (alias wattazoum) <email address hidden> Sun, 13 May 2007 08:04:52 +0200
+
 axel (1.0b-1.1) unstable; urgency=low

   * Non-maintainer upload.
only in patch2:
unchanged:
- --- axel-1.0b.orig/http.c
+++ axel-1.0b/http.c
@@ -41,7 +41,8 @@
   sprintf( conn->host, "%s:%i", host, port );
   if( !conn_set( tconn, proxy ) )
   {
- - sprintf( conn->request, _("Invalid proxy string: %s\n"), proxy );
+ /* We'll put the message in conn->headers, not in request */
+ sprintf( conn->headers, _("Invalid proxy string: %s\n"), proxy );
    return( 0 );
   }
   host = tconn->host;
@@ -55,7 +56,8 @@

  if( ( conn->fd = tcp_connect( host, port, conn->local_if ) ) == -1 )
  {
- - sprintf( conn->request, _("Unable to connect to server %s:%i\n"), host, port );
+ /* We'll put the message in conn->headers, not in request */
+ sprintf( conn->headers, _("Unable to connect to server %s:%i\n"), host, port );
   return( 0 );
  }

@@ -145,7 +147,8 @@
  {
   if( read( conn->fd, s, 1 ) <= 0 )
   {
- - sprintf( conn->request, _("Connection gone.\n") );
+ /* We'll put the message in conn->headers, not in request */
+ sprintf( conn->headers, _("Connection gone.\n") );
    return( 0 );
   }
   if( *s == '\r' )
only in patch2:
unchanged:
- --- axel-1.0b.orig/axel.c
+++ axel-1.0b/axel.c
@@ -444,7 +444,9 @@

  /* Terminate any thread still running */
  for( i = 0; i < axel->conf->num_connections; i ++ )
- - pthread_cancel( *axel->conn[i].setup_thread );
+ /* don't try to kill non existing thread */
+ if ( *axel->conn[i].setup_thread != 0 )
+ pthread_cancel( *axel->conn[i].setup_thread );

  /* Delete state file if necessary */
  if( axel->ready == 1 )

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGRr9b3oNqSZ7gEVoRAi4LAJsGUiHWSwGBkXy1LQz3Ft4AKDTGowCg4oAK
2IfVFoNJ03V1Hyl+/0rNbNA=
=ZoU3
-----END PGP SIGNATURE-----

Revision history for this message
Luke Yelavich (themuso) wrote :

Uploaded to gutsy. Please mark as fix released once the package has
succesfully built.

A couple of points for next time however.
* Please make sure to update the maintainer field to MOTU, as specified in the Debian Maintainer Field spec.
* Please do not use the requestsponsor script, as that doesn't attach the diff, and makes it harder to retrieve the patch to apply against the package.

Thanks for your work.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 13 May 2007 08:04:52 +0200
Source: axel
Binary: axel-kapt axel
Architecture: source
Version: 1.0b-1.1ubuntu1
Distribution: gutsy
Urgency: low
Maintainer: Ubuntu MOTU Developers <email address hidden>
Changed-By: Ouattara Oumar Aziz (alias wattazoum) <email address hidden>
Description:
 axel - A light download accelerator - Console version
 axel-kapt - A light download accelerator - Console version front-end
Changes:
 axel (1.0b-1.1ubuntu1) gutsy; urgency=low
 .
   * Fixed non existing thread killing
   * Error messages were never showed (cause they were misplaced)
   * CHanged maintainer field to MOTU.
Files:
 02f6fd7fc03e40c4198c763c5920873a 643 web optional axel_1.0b-1.1ubuntu1.dsc
 1dc5e93c4fe3fc690f5539d7514e0596 3924 web optional axel_1.0b-1.1ubuntu1.diff.gz
Original-Maintainer: Wilmer van der Gaast <email address hidden>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGSRD3jVefwtBjIM4RAqe2AKDSovCP+qA5mKEVQGlB4b5rlxmwxgCfUEPx
F8l88fSHJYBHMzRUDhtytgk=
=6tac
-----END PGP SIGNATURE-----

Changed in axel:
status: Unconfirmed → Fix Committed
Daniel T Chen (crimsun)
Changed in axel:
importance: Undecided → Wishlist
Revision history for this message
Oumar Aziz OUATTARA (wattazoum) wrote :

oki, I'll be careful next time :-)

Changed in axel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.