Launchpad itself

'Browse code' link doesn't work after reassigning the branch registrant

Bug #114791 reported by Rafael Proença
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Michael Hudson-Doyle
loggerhead
Invalid
Undecided
Unassigned

Bug Description

When reassigning a branch to another team, the http://codebrowse.launchpad.net doesn't change together.
I've registered a branch for a product in LP with the following command:
bzr push sftp://<email address hidden>/~cypherbios/aptoncd/main
Which resulted in https://code.launchpad.net/~cypherbios/aptoncd/main
Then I changed the registrant to ~aptoncd-team, and I got the following branch:
https://code.launchpad.net/~aptoncd-team/aptoncd/main

But the links on left side doesn't point to
http://codebrowse.launchpad.net/~aptoncd-team/aptoncd/main/changes
Instead still pointing to:
http://codebrowse.launchpad.net/~cypherbios/aptoncd/main/changes
[the same with rss and log]

Thanks.

Diogo Matsubara (matsubara)
Changed in launchpad-bazaar:
status: Unconfirmed → Confirmed
Michael Hudson-Doyle (mwhudson)
Changed in launchpad-bazaar:
assignee: nobody → mwhudson
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

David and I had a look at this and the problem is that loggerhead computes the url of each branchview when it is started, so when it tries to redirect from the BranchView object to its /changes url, it redirects to the old branch url.

There are probably a number of ways this could be fixed, but in the mean time, having launchpad link directly to the /changes url and not to some url which instantly redirects would solve the immediate problem...

Revision history for this message
David Allouche (ddaa) wrote :

Setting to High importance because this bug causes an apparent loss of service. From the user's perspective, it is a broken link in Launchpad.

Changed in launchpad-bazaar:
importance: Undecided → High
Revision history for this message
Robey Pointer (robey) wrote :

is there something that loggerhead can do to help here? (i don't totally understand the bug.)

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

The problem goes something like this:

When the launchpad creates a BranchView it sets its group_name to ~user/branch, but it is cached using (effectively) the id of the branch in the Launchpad DB.

Then, when the user reassigns the branch to '~team', and browse to /~team/branch, she sees the same BranchView object, which redirects to '/changes' but because the group_name is out of date it redirects to ~user/branch/changes, which is 404.

I no longer think this is a loggerhead bug, sorry for the noise.

Changed in loggerhead:
status: Unconfirmed → Rejected
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

This should be fixed now.

Changed in launchpad-bazaar:
status: Confirmed → Fix Released
Revision history for this message
Rafael Proença (cypherbios) wrote :

Thank you.
At least in the aptoncd/main and ~aptoncd-team branch it seems to be fixed.

Good job.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.