Evergreen

Attempting to delete a copy location with attached copies should display an error message

Bug #1154579 reported by Michael Peters
22
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
Evergreen 2.8-beta
2.6
Fix Released
Undecided
Unassigned
Evergreen 2.6.7
2.7
Fix Released
Undecided
Unassigned
Evergreen 2.7.4

Bug Description

Evergreen 2.3.2 > master
PostgreSQL 9.1
Ubuntu 12.04

When attempting to delete a copy location with items still attached, staff don't recieve any sort of error message letting them know why the delete failed.

The only source of knowing why it failed is the logs:

013-03-13 08:50:30 next-brick01-head open-ils.cstore: [ERR :13617:oils_sql.c:1098:13631755851331620] open-ils.cstore: Error committing transaction: 0 ERROR: update or delete on table "copy_location" violates foreign key constraint "copy_location_fkey" on table "copy"#012DETAIL: Key (id)=(7125) is still referenced from table "copy".

2013-03-13 08:50:30 next-brick01-head open-ils.circ: [ERR :13638:CStoreEditor.pm:114:13631755851331620] editor[1|1] request error open-ils.cstore.transaction.commit : [] : Exception: OpenSRF::DomainObject::oilsMethodException 2013-03-13T08:50:30 OpenILS::Utils::CStoreEditor /usr/local/share/perl/5.14.2/OpenILS/Utils/CStoreEditor.pm:440 <500> Error committing transaction

I'm requesting some sort of error display in the staff client when such an action fails. Currently, no message at all is displayed.

Ben Shum (bshum)
Changed in evergreen:
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
Galen Charlton (gmc) wrote :

Ran across this again while testing the new asset.copy_location deleted flag. Since unhandled exceptions are more of a bug than not, I've reclassified this bug. I also have a pull request ready to go at the tip of the user/gmcharlt/lp1154579_warn_on_acpl_delete_failure branch in the working/Evergreen repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1154579_warn_on_acpl_delete_failure

Changed in evergreen:
milestone: none → 2.8-beta
importance: Wishlist → Low
tags: added: pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

Pushed to master for 2.8-beta. Thanks Galen!

Changed in evergreen:
status: Confirmed → Fix Committed
Revision history for this message
Ben Shum (bshum) wrote :

Also backported to rel_2_7 and rel_2_6.

Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.