Add support for facebook stories
Bug #1155785 reported by
Robert Bruce Park
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Friends |
Fix Released
|
High
|
Robert Bruce Park | ||
Bug Description
Facebook has this concept of "stories", they show up in the feed just like messages, but they lack the "message" attribute, so when we try to publish them we get a mostly-empty deemodel row. Here is an example of the problematic JSON:
http://
I think adding support should be a simple matter of just checking for the presence of "story" and using it if it's there. I'll have to do a bit of research to determine if there's ever a situation in which "message" and "story" would both be present, because then we'll have to do a bit of work to combine those (most likely just message + "\n\n" + story, or maybe the other way around...) but hopefully they're mutually exclusive, that would be the simplest case to support.
Related branches
lp:~robru/friends/facebook-stories
- Ken VanDine: Approve
-
Diff: 189 lines (+128/-7)3 files modifiedfriends/protocols/facebook.py (+1/-1)
friends/tests/data/facebook-full.dat (+95/-0)
friends/tests/test_facebook.py (+32/-6)
lp:~super-friends/friends/raring
- PS Jenkins bot (community): Approve (continuous-integration)
- Ken VanDine: Approve
-
Diff: 3182 lines (+1267/-632)34 files modifieddebian/changelog (+18/-0)
debian/friends-dispatcher.install (+3/-0)
debian/rules (+4/-1)
friends/main.py (+9/-8)
friends/protocols/facebook.py (+47/-20)
friends/protocols/flickr.py (+5/-2)
friends/protocols/foursquare.py (+6/-1)
friends/protocols/twitter.py (+7/-3)
friends/service/dispatcher.py (+58/-8)
friends/tests/data/facebook-full.dat (+366/-1)
friends/tests/data/flickr-full.dat (+13/-1)
friends/tests/mocks.py (+50/-2)
friends/tests/test_account.py (+3/-62)
friends/tests/test_cache.py (+0/-4)
friends/tests/test_dispatcher.py (+75/-10)
friends/tests/test_facebook.py (+153/-72)
friends/tests/test_flickr.py (+59/-76)
friends/tests/test_foursquare.py (+7/-15)
friends/tests/test_identica.py (+2/-10)
friends/tests/test_mock_dispatcher.py (+0/-2)
friends/tests/test_model.py (+11/-2)
friends/tests/test_notify.py (+1/-14)
friends/tests/test_protocols.py (+154/-79)
friends/tests/test_shortener.py (+0/-2)
friends/tests/test_twitter.py (+52/-32)
friends/utils/account.py (+3/-23)
friends/utils/authentication.py (+6/-1)
friends/utils/base.py (+97/-143)
friends/utils/model.py (+9/-20)
service/configure.ac (+1/-0)
service/src/Makefile.am (+3/-2)
service/src/service.vala (+43/-15)
setup.py (+1/-0)
tools/debug_live.py (+1/-1)
| Changed in friends: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| assignee: | nobody → Robert Bruce Park (robru) |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #1 |
| Changed in friends: | |
| status: | Triaged → Fix Committed |
| Changed in friends: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:friends at revision 164, scheduled for release in friends, milestone Unknown