Evergreen

Currency symbol and format should not be in po-file translatable texts

Bug #1156545 reported by Pasi Kallinen
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Triaged
Medium
Pasi Kallinen

Bug Description

*EG master

The patron fines shown in OPAC (and in staff client) get the currency symbol from the gettext po-files. For en-US and fr-CA this is the dollar symbol. For most other countries, using the dollar does not make any sense.

If multiple languages are enabled for OPAC, and user switches the language, the currency symbol changes according to the translated string. The amount of fines does NOT change. This also applies to the staff client.

Solution:

The default currency and the currency format should be YAOUS, and the fines shown in OPAC should be in that format and currency.

I'm not sure more than one currency and converting between them is what EG should be doing.

Affected strings:

staff.cat.util.mark_item_damaged.charge_patron_prompt.message
staff.circ.utils.billable.amount
staff.circ.utils.fine_tally_text
staff.patron.bill_details.handle_void.confirm_void_billing
staff.patron.bills.void_all_billings.void.message
staff.patron.summary.patron_bill.money
"$%.2f" in Open-ILS/src/templates/opac/parts/header.tt2

Ben Shum (bshum)
Changed in evergreen:
status: New → Triaged
importance: Undecided → Medium
milestone: none → 2.4.0-rc
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-rc → none
Revision history for this message
Pasi Kallinen (paxed) wrote :

Here's a branch that adds a global.currency_fmt YAOUS: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/paxed/lp1156545

tags: added: pullrequest
Revision history for this message
Jason Etheridge (phasefx) wrote :

I think just having the sprintf.js script in the util_overlay file should be sufficient. I'd also be tempted to keep util.money.sanitize, and just put the new logic there. Fewer changes elsewhere.

Revision history for this message
Pasi Kallinen (paxed) wrote :

Updated the branch. as per Jason's suggestions.

Revision history for this message
Pasi Kallinen (paxed) wrote :

There's some more currency symbols in po-files, coming from Open-ILS/src/templates/acq/po/view.tt2, which my branch doesn't fix.

Revision history for this message
Pasi Kallinen (paxed) wrote :

I guess this could also somehow tie to acq.currency_type table ...

Revision history for this message
Pasi Kallinen (paxed) wrote :

Updated to master and squashed into one commit, plus some changes.

Revision history for this message
Pasi Kallinen (paxed) wrote :

I'm slowly chipping away at this - it's a bit bigger than I thought, those tentacles are all over the place and using currency as integer values is madness...

Changed in evergreen:
assignee: nobody → Pasi Kallinen (paxed)
Revision history for this message
Jason Etheridge (phasefx) wrote : Re: [Bug 1156545] Re: Currency symbol and format should not be in po-file translatable texts

You can blame me for a good bit of that. I don't like adding floats
together for fear of rounding errors and other representation quirks,
so I tried to do math in pennies whenever I could. :-)

http://stackoverflow.com/questions/588004/is-javascripts-floating-point-math-broken

Better would be to never do math on the client if we can help it. The
NUMERIC type in PostgreSQL is perfect.

Pasi Kallinen (paxed)
Changed in evergreen:
milestone: none → 2.5.0-m2
Revision history for this message
Pasi Kallinen (paxed) wrote :
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-m2 → 2.5.0-alpha1
Remington Steed (rjs7)
Changed in evergreen:
milestone: 2.5.0-alpha1 → 2.5.0-alpha2
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-alpha2 → 2.5.0-beta1
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-beta1 → 2.5.0-rc
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-rc → 2.5.1
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.5.1 → 2.5.2
Dan Wells (dbw2)
tags: removed: pullrequest
Changed in evergreen:
milestone: 2.5.2 → none
Revision history for this message
Eva Cerninakova (ece) wrote :

The currency symbols are untranslatable in the web staff client in the Circulations interface. It is possible to set the currency format for the TPAC in header.tt2 tpac template, however I have not found similar setting for the web staff client circulation interface. The Dollar sign is displayed next to the each money amount.
This was not such a problem in XUL client, because the currency symbol was only displayed in the owed amount overview under "Bills" pane name. However, in the web client the Dollar sign is used at every money amount, which is quite confusing for the circulation staff outside USA.
There should be definitely an option to set up the local currency for the Circulation interface.

Terran McCanna (tmccanna)
tags: added: webstaffclient
removed: staffclient
Timothy Means (tmeans-ncc)
tags: added: billing orgunitsettings
removed: webstaffclient
Terran McCanna (tmccanna)
tags: added: circ-billing
removed: billing
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.