[trunk/7.0]project stages reset at every update

Bug #1172149 reported by Lorenzo Battistini
28
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
OpenERP R&D Addons Team 1

Bug Description

openobject-addons/7.0 revno 9049

 - install project
 - change the name of 'merge' stage to 'deploy'
 - upgrade project

'merge' stage is back

Related branches

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 1 (openerp-dev-addons1)
importance: Undecided → Low
status: New → Confirmed
summary: - project stages reset at every update
+ [trunk/7.0]project stages reset at every update
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Chandni Gandhi(OpenERP) (cga-openerp) wrote :

Hello,

It has been fixed in to : https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1172149-cga

Revision No:8690
Revision ID:<email address hidden>

It will be merged soon.

Thanks.
CGA.

Changed in openobject-addons:
status: In Progress → Fix Committed
Changed in ocb-addons:
status: New → Fix Committed
importance: Undecided → Low
Revision history for this message
Martin Trigaux (OpenERP) (mat-openerp) wrote :

Hello,

You are right we should keep the value. I have merged this (slightly modified, cf MP of Alex) in 7.0.

Thanks for the report

revno: 9620 [merge]
revision-id: <email address hidden>

Changed in openobject-addons:
status: Fix Committed → Fix Released
Revision history for this message
Lorenzo Battistini (elbati) wrote : Re: [Bug 1172149] Re: [trunk/7.0]project stages reset at every update

On 11/20/2013 05:10 PM, Martin Trigaux (OpenERP) wrote:
> Hello,
>
> You are right we should keep the value. I have merged this (slightly
> modified, cf MP of Alex) in 7.0.

Hello Martin,
why should subtypes ('mail.message.subtype') be reset at every update?

Revision history for this message
Martin Trigaux (OpenERP) (mat-openerp) wrote :

Hello Lorenzo,

As mentioned Stephan on the MP, quite often we put it in no update but I don't think this is the best idea. Depending what you do on these data:

- Delete subtype -> no impact, would be recreate at update with or without noupdate, ignored by the system if inexistent
- Modify name/description -> with noupdate could get inconsistent behaviour (rename "task created" into "task deleted", won't get why it is still trigged at creation)
- Modify res_model/parent_id -> could break stuff

So I think it's a bit like views, it is good to know it would go back to normal with an update if you have broken stuff.

Where it could get interesting to change it is when you want to tweak the system to a specific case (eg: my company creates piano, I change "task created" into "piano started") but in that case you could get the same result with translations.

So, stop me if I am wrong, there is not much reasons to change the data for the subtypes (the evaluation conditions are in python anyway). If you need to change it, you will probably create new ones in your custom modules.

I don't think we need to change it everywhere in OpenERP to noupdate="0" (little impact) but it's probably something we could do during refactoring.

no longer affects: ocb-addons
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.