Mahara

License issue on vanilla 1.7

Bug #1174540 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Aaron Wells
1.7
Fix Released
Low
Aaron Wells
Mahara 1.7.1

Bug Description

from Gregor at https://mahara.org/interaction/forum/topic.php?id=5394

Installed fresh instance of Mahara 1.7.0. I have only one user - admin user. No data is set, everything is default as install process created it.

Created new page and tried to add Textbox block. The rendering of config form took forever... Upon investigation I found out that it is caused because 'license' and 'license_advanced' pieform elements are created without 'type' which would indicate the type of Pieform. This is needed in line 930 of 'build_configure_form' function in file htdocs/blocktype/lib.php which tries to reference Pieform javascript function:

line 930: $function = 'pieform_element_' . $element['type'] . '_views_js';

I suspect it can't be done since 'type' index isn't set...

Haven't added it to bugtracker since I want you guys to please confirm this.

Kind regards,
Gregor

-------------------

When I turn on the license, the problem vanishes...

Tags: license
Revision history for this message
Aaron Wells (u-aaronw) wrote :

I was unable to replicate, but I did notice a warning generated on line 930 htdocs/blocktype/lib.php as Gregor described, which is caused because the placeholder elements returned by license_form_el_advanced() and license_form_el_basic() don't have a 'type' key. For me, the theories would show up on the next page load. My theory is that for some reason in Gregor's install these warnings were popping up in his JSON responses, fouling them up so that the config form hung.

Here's a patch to squelch those warnings: https://reviews.mahara.org/2099

Changed in mahara:
milestone: none → 1.8.0rc1
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2099
Committed: http://gitorious.org/mahara/mahara/commit/e48c5e8c3a0f49236f944b5beb59ed6c0b7bca9a
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit e48c5e8c3a0f49236f944b5beb59ed6c0b7bca9a
Author: Aaron Wells <email address hidden>
Date: Tue Apr 30 17:16:04 2013 +1200

Fix warnings that happen when licenses are disabled

Bug#1174540. Some warnings were because the placeholder empty elements
returned the license_form_el_* functions were missing their "type". Others
were because code for some content was trying to process the license elements
even if licenses were disabled and thus the elements were missing.

Signed-off-by: Aaron Wells <email address hidden>
Change-Id: I961fec3aa4fefb737b497638c59a0426db95d04b

Aaron Wells (u-aaronw)
Changed in mahara:
status: New → Fix Committed
importance: Undecided → Low
assignee: nobody → Aaron Wells (u-aaronw)
tags: added: license
summary: - Lincense issue on vanilla 1.7
+ License issue on vanilla 1.7
Revision history for this message
Aaron Wells (u-aaronw) wrote :

backported to 1.7: https://reviews.mahara.org/2133

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/2133
Committed: http://gitorious.org/mahara/mahara/commit/c084c41b0dcfe4a8116fe8f73ce9123a8655124e
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.7_STABLE

commit c084c41b0dcfe4a8116fe8f73ce9123a8655124e
Author: Aaron Wells <email address hidden>
Date: Tue Apr 30 17:16:04 2013 +1200

Fix warnings that happen when licenses are disabled

Bug#1174540. Some warnings were because the placeholder empty elements
returned the license_form_el_* functions were missing their "type". Others
were because code for some content was trying to process the license elements
even if licenses were disabled and thus the elements were missing.

Signed-off-by: Aaron Wells <email address hidden>
Change-Id: I961fec3aa4fefb737b497638c59a0426db95d04b

Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.8.0rc1 → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.