Evergreen

2.3-2.4 upgrade: drop tsearch2 extension only if it exists

Bug #1175287 reported by Galen Charlton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
Evergreen 2.4.0

Bug Description

A sufficiently old Evergreen database would have had tsearch2 installed as a contrib, not an extension, and would have worked just fine if the extension was never installed. Consequently, the 'drop extension if exists' form should be used in the upgrade scripts, to avoid a spurious abort when upgrading such databases.

Evergreen master

Tags: pullrequest
Revision history for this message
Galen Charlton (gmc) wrote :

Patch is available in the working/Evergreen repository in the user/gmcharlt/lp1175287_drop_tsearch2_only_if_exists branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1175287_drop_tsearch2_only_if_exists

Changed in evergreen:
importance: Undecided → Medium
milestone: none → 2.4.0
tags: added: pullrequest
Revision history for this message
Thomas Berezansky (tsbere) wrote :

Installed as a contrib and not an extension doesn't mean it shouldn't be removed. That just makes it harder to remove the extra pieces that are floating around.

It might be better to include "upgrade to extension from contrib" as a step (or set of steps, one for each contrib) before then removing the extension to do the cleanup.

Revision history for this message
Galen Charlton (gmc) wrote :

After discussing with Thomas in #evergreen, I'm replacing my pull request with the tip of the user/gmcharlt/lp1175287_drop_tsearch2_more_fully branch in the working/Evergreen repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1175287_drop_tsearch2_more_fully

Revision history for this message
Mike Rylander (mrylander) wrote :

ARG! Picked into master, 2.4 and 2.4.0-tag. Thanks, both of you, for cleaning that up.

Changed in evergreen:
status: New → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.