Evergreen

Expose bib source in TPAC

Bug #1178377 reported by Jeff Davis
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned
Evergreen 2.9-beta

Bug Description

It would be nice if a bib record's source were exposed as an attribute in the TPAC.

Example use case:
We import e-resource records from a third party, using the bib source to indicate where the records came from. Patrons can place holds on these titles, but they must be placed via the vendor website, not in Evergreen. By exposing the bib source, we can alter the Place Hold link for these records to point at the vendor website.

I have a patch to expose the bib source, which I will push to the working repo momentarily.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

See user/jeffdavis/lp1178377-bib-source-in-tpac in working/Evergreen.git:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=d058329872e5fb429c714fbeab484ee7005ec5e0

This is based on master, but it should apply cleanly all the way back to 2.2, I think.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

The above patch makes the bib source available in TPAC, but doesn't change anything in terms of how records are displayed.

Here is a local customization that makes use of the above patch to change Place Hold links in 2.2 TPAC, as per the use case in the original bug report above:

http://git.sitka.bclibraries.ca/gitweb/?p=sitka/evergreen.git;a=commitdiff;h=2164bfc93a8c006ef23d4c6ac0f78204db3210ce

tags: added: pullrequest
Ben Shum (bshum)
Changed in evergreen:
milestone: none → 2.5.0-m1
importance: Undecided → Wishlist
status: New → Triaged
Revision history for this message
Dan Wells (dbw2) wrote :

Jeff, thanks for taking this on, it looks like a good addition. However, it appears your branch is missing the changes to 990.schema.unapi.sql (we only have the upgrade file). Get that added, and hopefully this can get in for 2.5.0-m1.

Please reply if this request isn't clear enough. Thanks again!

Changed in evergreen:
status: Triaged → Incomplete
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Whoops. How's this:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1178377-bib-source-in-tpac-2

Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-m1 → 2.5.0-m2
Revision history for this message
Dan Wells (dbw2) wrote :

I have reviewed this more thoroughly now. It works, but I still have at least one concern. Since this new 'bib_source' tag isn't optional, there is no longer a way to get a "clean" marc-xml record back. I think it needs to be requested via the 'includes' text array, similar to the other add-on type data. What do you think?

Thanks,
Dan

Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-m2 → 2.5.0-alpha1
Revision history for this message
Mike Rylander (mrylander) wrote :

I agree with Dan, re using the 'includes' mechanism to indicate that we want this.

Remington Steed (rjs7)
Changed in evergreen:
milestone: 2.5.0-alpha1 → 2.5.0-alpha2
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-alpha2 → 2.5.0-beta1
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-beta1 → none
Revision history for this message
Doug Kyle (dkyle) wrote :

A couple minor additions to Jeff Davis' work to make the bib_source optional.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=6ea18affb416988cddf6d76abab3b134a4ad015e

Revision history for this message
Mike Rylander (mrylander) wrote :

Eyeballing it, that looks great. All that's left is the baseline schema changes. Thanks, Doug!

Revision history for this message
Doug Kyle (dkyle) wrote :

Baseline schema has been changed

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Doug's changes are in branch user/dkyle/lp1178377-bib-source-in-tpac in the working repo. However, that branch is based on some pretty old (2.5-era) code.

I've created a new working branch which applies all of these changes to master (and squashes Doug's two commits together):

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1178377-bib-source-in-tpac-final

Changed in evergreen:
milestone: none → 2.next
status: Incomplete → Triaged
Revision history for this message
Kathy Lussier (klussier) wrote :

We'll need a release notes entry before this code goes in.

tags: added: needsreleasenote
Jeff Davis (jdavis-sitka)
Changed in evergreen:
milestone: 2.next → 2.9-alpha
Jason Stephenson (jstephenson)
Changed in evergreen:
milestone: 2.9-alpha → 2.9-beta
Revision history for this message
Ben Shum (bshum) wrote :

Added a quick release note for this and it has been pushed to master for 2.9-beta. Cheers, all!

Changed in evergreen:
status: Triaged → Fix Committed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.